Repository navigation
FIX: do not cache exceptions - #25470
Merged
timhoffm merged 2 commits intoMar 15, 2023
Merged
timhoffm merged 2 commits into
timhoffm merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This leads to caching the tracebacks which can keep user's objects in local namespaces alive indefinitely. This can lead to very surprising memory issues for users and will result in incorrect tracebacks. Responsive to matplotlib#25406
This is to help prevent reference cycles between the frames and the locals in that frame. While garbage collection should in most cases take care of this eventually, we can help the interpreter out and break the cycle before we return.
tacaswell
force-pushed
the
fix/donot_cache_exceptions
branch
from
7d5d486 to
01390c5
Compare
March 15, 2023 19:54
Copy link
Copy Markdown
Member
Author
|
Manually confirmed that the new test passes on pypy3. |
Sorry, something went wrong.
ksunden
approved these changes
Mar 15, 2023
timhoffm
approved these changes
Mar 15, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 15, 2023
ksunden
added a commit
that referenced
this pull request
Mar 16, 2023
…470-on-v3.7.x Backport PR #25470 on branch v3.7.x (FIX: do not cache exceptions)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leads to caching the tracebacks which can keep user's objects in local namespaces alive indefinitely. This can lead to very surprising memory issues for users and will result in incorrect tracebacks.
Responsive to #25406
PR Summary
PR Checklist
Documentation and Tests