Repository navigation
Remove unnecessary calls to Formatter.set_locs. - #25510
Merged
oscargus merged 1 commit intoMar 20, 2023
Merged
oscargus merged 1 commit into
oscargus merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
set_ticks actually already calls set_locs, so the calls here are redundant. Preparatory to deprecating set_locs as a public API.
rcomer
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_ticks actually already calls set_locs, so the calls here are redundant.
Preparatory to deprecating set_locs as a public API (#13323, #5787 (comment)).
PR Summary
PR Checklist
Documentation and Tests
Release Notes