Repository navigation
DOC: Fix the bars having numeric value of cm but labeled as inches - #25518
Merged
timhoffm merged 1 commit intoMar 23, 2023
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is admittedly more of a band-aid than a proper fix, but at least make the generated figure correct. The underlying problem is the more fundemental one of inconsistent units behavior in which some artists can be re-united after plotting (e.g. Line2D), while many others (e.g. Collections) cannot. Thus, until that is addressed (which is one of the goals of the data-prototype work), simply setting units early is as good as we can do. Closes matplotlib#5051
Copy link
Copy Markdown
Member
Author
|
Current version (the dataset changed from 3.6 to 3.7 here, but the units misbehavior was retained): https://matplotlib.org/3.7.0/gallery/units/bar_unit_demo.html Note that the values are set in cm, but the units are supposed to be "inches", but the plotted values are the same as the cm values. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'm 95% sure unit re-setting is possible only for Line2D, and was never implemented for anything else. |
Sorry, something went wrong.
jklymak
approved these changes
Mar 21, 2023
timhoffm
approved these changes
Mar 23, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 23, 2023
…of cm but labeled as inches
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 23, 2023
…of cm but labeled as inches
oscargus
added a commit
that referenced
this pull request
Mar 23, 2023
…518-on-v3.7.1-doc Backport PR #25518 on branch v3.7.1-doc (DOC: Fix the bars having numeric value of cm but labeled as inches)
oscargus
added a commit
that referenced
this pull request
Mar 23, 2023
…518-on-v3.7.x Backport PR #25518 on branch v3.7.x (DOC: Fix the bars having numeric value of cm but labeled as inches)
Copy link
Copy Markdown
Contributor
|
closed a 4-digit issue. Yeah! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is admittedly more of a band-aid than a proper fix, but at least
make the generated figure correct.
The underlying problem is the more fundemental one of inconsistent units
behavior in which some artists can be re-united after plotting (e.g.
Line2D), while many others (e.g. Collections) cannot.
Thus, until that is addressed (which is one of the goals of the
data-prototype work), simply setting units early is as good as we can
do.
Closes #5051
PR Summary
PR Checklist
Documentation and Tests
Release Notes