Repository navigation
Remove print_figure overrides in backend subclasses - #25713
Merged
tacaswell merged 1 commit intoApr 19, 2023
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AFAICT, `print_figure` is only called in `savefig`, and thus has no relation to backend drawing. We went through a lot of trouble to make `savefig` self-contained, so if this really had any effect, it would be a bug in it instead. But other backends don't do this override and seem to work fine, so these seem superfluous as well. After this change, just opening a window in Qt and using the save button did not seem to break anything, nor did running `savefig` with an interactive window open. I did not test Wx, but given the callers of `print_figure`, I don't see how it could be different. Fixes matplotlib#5234
timhoffm
approved these changes
Apr 19, 2023
Copy link
Copy Markdown
Member
|
Other option would be to change these to draw_idle, but agree that if this is needed here that is a bug better fixed else where. |
Sorry, something went wrong.
tacaswell
approved these changes
Apr 19, 2023
This was referenced Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
AFAICT, print_figure is only called in savefig, and thus has no relation to backend drawing. We went through a lot of trouble to make savefig self-contained, so if this really had any effect, it would be a bug in it instead. But other backends don't do this override and seem to work fine, so these seem superfluous as well.
After this change, just opening a window in Qt and using the save button did not seem to break anything, nor did running savefig with an interactive window open. I did not test Wx, but given the callers of print_figure, I don't see how it could be different.
Fixes #5234
PR Checklist
Documentation and Tests
Release Notes