FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Small axislines.Axes cleanups. by anntzer · Pull Request #25774 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Small axislines.Axes cleanups. - #25774

Merged
oscargus merged 1 commit into
matplotlib:mainfrom
anntzer:al
Apr 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Small axislines.Axes cleanups.#25774
oscargus merged 1 commit into
matplotlib:mainfrom
anntzer:al

Conversation

anntzer commented Apr 26, 2023

Copy link
Copy Markdown
Contributor
  • Deprecate the "callable axes" API, which is not present anywhere else nor documented nor tested.
  • No need to set the transform on the GridlinesCollection; _set_artist_props takes care of that.

PR Summary

PR Checklist

Linked Issue

  • Added "closes #0000" in the PR description to link it to the original issue.

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

anntzer added this to the v3.8.0 milestone Apr 26, 2023
ksunden reviewed Apr 26, 2023
View reviewed changes
Comment thread doc/api/next_api_changes/deprecations/25774-AL.rst Outdated
@@ -0,0 +1,4 @@
Callable axisartist Axes
~~~~~~~~~~~~~~~~~~~~~~~~
Calling an axisartit Axes to mean `.Axes.axis` is deprecated; explicitly call

ksunden Apr 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Calling an axisartit Axes to mean `.Axes.axis` is deprecated; explicitly call
Calling an axisartist Axes to mean `.Axes.axis` is deprecated; explicitly call

anntzer Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

woops, fixed

Small axislines.Axes cleanups.
68266ef 
- Deprecate the "callable axes" API, which is not present anywhere else
  nor documented nor tested.
- No need to set the transform on the GridlinesCollection;
  _set_artist_props takes care of that.
oscargus merged commit b3c38d7 into matplotlib:main Apr 27, 2023
anntzer deleted the al branch April 27, 2023 10:53
ksunden mentioned this pull request Apr 27, 2023
Merged
7 tasks
ksunden added a commit to ksunden/matplotlib that referenced this pull request Apr 27, 2023
Fix release note reference to pyplot.axis
d2c72f4 
xref matplotlib#25774
eslothower pushed a commit to eslothower/matplotlib that referenced this pull request May 3, 2023
Fix release note reference to pyplot.axis
033ee5a 
xref matplotlib#25774
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Fix release note reference to pyplot.axis
3b6ad75 
xref matplotlib#25774
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Fix release note reference to pyplot.axis
f93fa3e 
xref matplotlib#25774
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Fix release note reference to pyplot.axis
54296ab 
xref matplotlib#25774
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Fix release note reference to pyplot.axis
e43363f 
xref matplotlib#25774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ksunden ksunden left review comments
timhoffm timhoffm approved these changes
oscargus oscargus approved these changes

Assignees

No one assigned

Labels

Maintenance topic: mpl_toolkit

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL