Repository navigation
More consistent handling of 'None' vs. 'none' - #26004
Draft
lucavribeiro wants to merge 3 commits into
Draft
lucavribeiro wants to merge 3 commits into
lucavribeiro wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks you! There is also #23056 which does the same thing. |
Sorry, something went wrong.
5 tasks
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lucavribeiro
marked this pull request as draft
July 8, 2023 12:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
closes #19300
Hello, I've made some changes to improve the consistency handling of 'None' vs 'none' when it comes to the linestyles code. Just like proposed in the issue, i chose 'none' since its looks more distant than None (like NULL)
PR checklist