Repository navigation
Let collections return linewidths "as is", without cycling. - #26043
Open
anntzer wants to merge 1 commit into
Open
anntzer wants to merge 1 commit into
anntzer wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously, collections would return a "cycled" version of linewidths which is internally used to scale dashes (this scaling needs to be done at property setting time, because of the interaction with styles). While it makes sense to store the cycled scaled dashes, there's no need to also store the cycled linewidths or pass that to the backend code -- directly using the uncycled linewidths seems simpler. This also makes collection.get_linewidths() return something much closer to whatever was passed in -- see the test change in test_lslw_bcast.
Copy link
Copy Markdown
Member
|
If we are to change the return values of these things, I'd like to chip in #23056 I foresee a major rebase effort if this goes in before (although I may be wrong). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I don't really mind either way, though I'd say the change here (making get_linewidths() return something closer to what was passed in) is more useful than the change in #23056 (which makes get_linestyle() return something different from what was passed in, if I understand it correctly). (Notwithstanding the other benefits of #23056.) |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, collections would return a "cycled" version of linewidths which is internally used to scale dashes (this scaling needs to be done at property setting time, because of the interaction with styles).
While it makes sense to store the cycled scaled dashes, there's no need to also store the cycled linewidths or pass that to the backend code -- directly using the uncycled linewidths seems simpler. This also makes collection.get_linewidths() return something much closer to whatever was passed in -- see the test change in test_lslw_bcast.
Also, "broadcasting" has a technical meaning in numpy; it's not the same thing as cycling.
PR summary
PR checklist