FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ENH: Collection.set_paths by rcomer · Pull Request #26342 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

ENH: Collection.set_paths - #26342

Merged
greglucas merged 1 commit into
matplotlib:mainfrom
rcomer:cs-set_paths
Jul 19, 2023
ConversationCommits (1)ChecksFiles changed
Merged

ENH: Collection.set_paths#26342
greglucas merged 1 commit into
matplotlib:mainfrom
rcomer:cs-set_paths

Conversation

rcomer commented Jul 18, 2023

Copy link
Copy Markdown
Member

PR summary

Closes #26340

I didn't add a changenote because I think this is covered by "Setting properties on the ContourSet can now usually be done using standard collection setters"
https://matplotlib.org/devdocs/api/next_api_changes/behavior/25247-AL.html

PR checklist

rcomer commented Jul 18, 2023

Copy link
Copy Markdown
Member Author

I have also tested this for the Cartopy case.

rcomer added this to the v3.8.0 milestone Jul 18, 2023
greglucas reviewed Jul 19, 2023
View reviewed changes
Comment thread lib/matplotlib/contour.py Outdated
Comment on lines +980 to +982
def set_paths(self, paths):
self._paths = paths
self.stale = True

greglucas Jul 19, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree with @anntzer's comment #26340 (comment)
I think we could just add this change to Collection.set_paths(paths) method definition instead so others can also subclass and take advantage of it (could remove the method definition from PathCollection then too I think.

rcomer Jul 19, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah sorry, I misread @anntzer's comment. I've now updated Collection.set_paths. I left my test in because set_paths does not appear in test_collection.py. I assume the ContourSet is as good a place as any to make sure this code path is covered?

rcomer changed the title ENH: ContourSet.set_paths ENH: Collection.set_paths Jul 19, 2023
greglucas merged commit 17412bf into matplotlib:main Jul 19, 2023
rcomer mentioned this pull request Jul 19, 2023
Merged
rcomer deleted the cs-set_paths branch July 19, 2023 13:47
rcomer mentioned this pull request Oct 16, 2025
Merged
5 tasks
larsoner mentioned this pull request Aug 31, 2026
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
greglucas greglucas approved these changes

Assignees

No one assigned

Labels

topic: contour

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

[ENH]: ContourSet.set_paths

3 participants

Back | FazBrowse Home | New Git URL