Repository navigation
Fixes for pycodestyle v2.11 - #26414
oscargus merged 1 commit into
Conversation
Sorry, something went wrong.
|
Changed the milestone as this is also library code. |
Sorry, something went wrong.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout v3.7.x git pull
git cherry-pick -x -m1 f7a8cabc1cf1ac9b35502f08e764d74d07d865ac
git commit -am 'Backport PR #26414: Fixes for pycodestyle v2.11'
git push YOURFORK v3.7.x:auto-backport-of-pr-26414-on-v3.7.x
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the Still Needs Manual Backport label once the PR gets merged. If these instructions are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
|
I assumed we would want to backport this to the doc branch as the CI is failing there too - #26413. |
Sorry, something went wrong.
|
We don't backport to that branch because it wouldn't have any effect, but this will, so it's okay to backport. |
Sorry, something went wrong.
(cherry picked from commit f7a8cab)
…3.7.2-doc Backport PR #26414: Fixes for pycodestyle v2.11
(cherry picked from commit f7a8cab)
…26414-on-v3.7.2-doc Backport PR matplotlib#26414: Fixes for pycodestyle v2.11
PR summary
flake8 is currently failing in CI with
I think this is the relevant change: PyCQA/pycodestyle#1086
In the bubble example, it looks like the type check was there just to make sure we get an array-like out of the method. We can achieve that with the keepdims keyword.
Everywhere else I just replaced == with is as that preserves existing behaviour so seems safest. Possibly some places could have used isinstance instead but I do not know if there is an advantage to changing it to that (and I also do not know those parts of the code well enough to make that call).
PR checklist