FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[DOC]: codespace link in contribute index by story645 · Pull Request #26573 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

[DOC]: codespace link in contribute index #26573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksunden merged 1 commit into from
Aug 22, 2023
Conversation 4 Commits 1 Checks 0 Files changed
Merged

[DOC]: codespace link in contribute index #26573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .rst  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
64 changes: 33 additions & 31 deletions doc/devel/index.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,53 +12,55 @@ and implementing new features, helping the community...
New contributors
================

.. card::

.. grid:: 1 1 2 2
:class-row: sd-align-minor-center
.. grid:: 1 1 2 2
:class-row: sd-align-minor-center

.. grid-item::
:class: sd-fs-5
.. grid-item::
:class: sd-fs-5

:octicon:`info;1em;sd-text-info` :ref:`Where should I start? <start-contributing>`
:octicon:`info;1em;sd-text-info` :ref:`Where should I start? <start-contributing>`

:octicon:`question;1em;sd-text-info` :ref:`Where should I ask questions? <get_connected>`
:octicon:`question;1em;sd-text-info` :ref:`Where should I ask questions? <get_connected>`

:octicon:`issue-opened;1em;sd-text-info` :ref:`What are "good-first-issues"? <new_contributors>`
:octicon:`issue-opened;1em;sd-text-info` :ref:`What are "good-first-issues"? <new_contributors>`

:octicon:`git-pull-request;1em;sd-text-info` :ref:`How do I claim an issue? <managing_issues_prs>`
:octicon:`git-pull-request;1em;sd-text-info` :ref:`How do I claim an issue? <managing_issues_prs>`

.. :octicon:`codespaces;1em;sd-text-info` placeholder for codespaces link
:octicon:`codespaces;1em;sd-text-info` :ref:`How do I start a pull request? <how-to-contribute>`

story645 Aug 22, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not attached to the focus on a PR given I used the pr icon in the last bullet, just can't think of anything else right now

melissawm Aug 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry I had misread - this looks good to me, we don't want it to be too long either. Maybe "How do I start a pull request on the browser?" if it fits...

story645 Aug 22, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So the link goes to the local + codespace contribute instructions, which I think is fine b/c some contributors won't have the bandwidth to use codespaces. I think what I'm struggling w/ is differentiating that this is the nuts and bolts writing portion of the process rather than the exploratory find something to work on stage.

melissawm Aug 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That sounds good then, thanks!

.. grid-item::
.. grid-item::

.. grid:: 1
:gutter: 1
:class-row: sd-fs-5
.. grid:: 1
:gutter: 1
:class-row: sd-fs-5

.. grid-item-card::
:link: request-a-new-feature
:link-type: ref
.. grid-item-card::
:link: request-a-new-feature
:link-type: ref
:shadow: none

:octicon:`light-bulb;1em;sd-text-info` Request new feature
:octicon:`light-bulb;1em;sd-text-info` Request new feature

.. grid-item-card::
:link: submitting-a-bug-report
:link-type: ref
.. grid-item-card::
:link: submitting-a-bug-report
:link-type: ref
:shadow: none

:octicon:`bug;1em;sd-text-info` Submit bug report
:octicon:`bug;1em;sd-text-info` Submit bug report

.. grid-item-card::
:link: contributing-code
:link-type: ref
.. grid-item-card::
:link: contributing-code
:link-type: ref
:shadow: none

:octicon:`code;1em;sd-text-info` Contribute code
:octicon:`code;1em;sd-text-info` Contribute code

.. grid-item-card::
:link: documenting-matplotlib
:link-type: ref
.. grid-item-card::
:link: documenting-matplotlib
:link-type: ref
:shadow: none

:octicon:`note;1em;sd-text-info` Write documentation
:octicon:`note;1em;sd-text-info` Write documentation

If you are new to contributing, we recommend that you first read our
:ref:`contributing guide<contributing>`. If you are contributing code or
Expand Down
Back | FazBrowse Home | New Git URL