setupext: support using environment variables for dependencies - #26679
mathstuf wants to merge 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
|
FWIW, before I go and write docs for this, I'd like to know that it's a suitable solution to the problem. If needed, the QHULL_* variables can be additionally guarded behind a Windows check. |
Sorry, something went wrong.
|
Looks like there are some related failures in CI - @mathstuf would you take a look? Let us know if you need help. Thanks! |
Sorry, something went wrong.
On Windows, without Conda or the libraries being in default locations,
matplotlib has problems finding freetype and qhull. Add ultimate
fallback solutions using very specific environment variables named
`{FREETYPE,QHULL}_{INCLUDE,LIBRARY}_DIRS`.
|
Whoops, indeed. I had typos and copy pasta that I had fixed in testing but had inconsistently applied back to my development machine. Applied here too now. |
Sorry, something went wrong.
|
That would be suitable to me if meson can reliably find these dependencies on Windows then. It seems for .pc to be reliable I have to go chase down if (NOT WIN32) guarding conditions on the .pc file generation/installation in some projects (libpng for example). |
Sorry, something went wrong.
|
Seems to be obsolete since #26621 removed setupext.py. |
Sorry, something went wrong.
It should be; we don't have any platform-specific checks for dependencies, just the standard dependency or fallback to find_library. Please open a new bug if that remains an issue. |
Sorry, something went wrong.
|
Will know the next time we go and bump packages. Thanks :) . |
Sorry, something went wrong.
PR summary
On Windows, without Conda or the libraries being in default locations, matplotlib has problems finding freetype and qhull. Add ultimate fallback solutions using very specific environment variables named {FREETYPE,QHULL}_{INCLUDE,LIBRARY}_DIRS.
My attempts at using CL and LINK were failing; not sure if the migration to meson made these obsolete or not.
PR checklist