Remove backend 3.7-deprecated API by issamarabi · Pull Request #26962 · matplotlib/matplotlib · GitHub

PR summary

This PR addresses the removal of classes that were deprecated in version 3.7. (issue #26865)

Changes:

Removed PsBackendHelper class which was deprecated since 3.7.
Removed the ps_backend_helper attribute from the __getattr__ class which referenced the now-removed PsBackendHelper.
Removed the ServerThread class which was also deprecated since 3.7.

PR checklist

"Almost closes [MNT]: Remove 3.7-deprecated API #26865" is in the body of the PR description to link the related issue
new and changed code is tested
Plotting related features are demonstrated in an example
New Features and API Changes are noted with a directive and release note
Documentation complies with general and docstring guidelines

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

This looks good, but it needs an API change note for the removals. There's also something in src/_backend_agg_wrapper.cpp that's backend-related if you want to remove that too.

There's also something in src/_backend_agg_wrapper.cpp that's backend-related if you want to remove that too.

I've removed the deprecated methods PyBufferRegion_to_string and PyBufferRegion_to_string_argb from src/_backend_agg_wrapper.cpp as suggested. The API change notes have been updated accordingly. Please review.

Doc build is failing because of the build system change, should be fixed by rebasing again onto current upstream/main.

Also the changelog note wants a newline at the end (this is what is failing pre-commit CI)

hey can i work on this issue

This is not an open issue; it's an open pull request waiting for a reply from the original submitter, @issamarabi. There is no work to be done here unless the original submitter has disappeared (and it's not clear that enough time has passed for that to be the case).

@issamarabi please report back whether you are you planning to continue this work.

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

…gion_to_string_argb This commit removes two deprecated methods, PyBufferRegion_to_string and PyBufferRegion_to_string_argb, from src/_backend_agg_wrapper.cpp, deprecated since version 3.7. Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

… methods from 3.7 This commit updates the API change notes to reflect the removal of deprecated Python classes and C++ methods. Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Removed `to_string` and `to_string_argb` methods from `PyBufferRegion_init_type` Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Co-authored-by: Kyle Sunden <git@ksunden.space>

Update doc format Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Sorry about that!

Should just be the small amount of clean up in the release note to quell sphinx warnings.

If you are comfortable squashing your commits down, that would also be nice (though we can do that on merge as well).

Co-authored-by: Kyle Sunden <git@ksunden.space>

I created several commits to separate distinct changes. I think this will help future coders. I also wouldn't know how to create one commit message that encompasses all the changes I made.

I created several commits to separate distinct changes. I think this will help future coders. I also wouldn't know how to create one commit message that encompasses all the changes I made.

I think the PR title would be fine as a commit message, though you can also create a multi-line commit message if you want to add more detail. In general, Matplotlib tries to keep commits to a minimum and, while we are not overly strict about that, it would be very unusual for this project to merge 14 separate commits from a single PR.

The code looks fine; the commits could be squashed a bit.

Thanks @issamarabi! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

github-actions Bot reviewed Sep 29, 2023

View reviewed changes

QuLogic added the Maintenance label Sep 30, 2023

QuLogic added this to the v3.9.0 milestone Sep 30, 2023

QuLogic mentioned this pull request Sep 29, 2023

[MNT]: Remove 3.7-deprecated API #26865

Closed

14 tasks done

ksunden requested changes Oct 2, 2023

View reviewed changes

Comment thread doc/api/next_api_changes/removals/26962-IA.rst Outdated

Comment thread doc/api/next_api_changes/removals/26962-IA.rst Outdated

QuLogic reviewed Oct 5, 2023

View reviewed changes

Comment thread src/_backend_agg_wrapper.cpp

github-actions Bot added status: needs rebase and removed status: needs rebase labels Oct 5, 2023

issamarabi force-pushed the remove-backend-deprecations branch from ff6eca4 to 3f84b61 Compare October 5, 2023 13:17

ksunden requested changes Oct 5, 2023

View reviewed changes

Comment thread doc/api/next_api_changes/removals/26962-IA.rst Outdated

QuLogic reviewed Oct 5, 2023

View reviewed changes

Comment thread doc/api/next_api_changes/removals/26962-IA.rst Outdated

Comment thread src/_backend_agg.cpp

This was referenced Oct 13, 2023

Update contour.py #27078

Closed

Update axislines.py #27079

Closed

Vishnu9535 mentioned this pull request Oct 30, 2023

Remove backend 3.7-deprecated API #26962 #27225

Closed

5 tasks

issamarabi and others added 10 commits November 2, 2023 08:30

remove deprecated class PsBackendHelper

e745f28

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

remove deprecated class ServerThread

1e61d8f

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

remove deprecated class PsBackendHelper dependency

70c6723

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

remove blank lines

e1916bb

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Update API change notes to document removal of deprecated classes and…

7633fff

… methods from 3.7 This commit updates the API change notes to reflect the removal of deprecated Python classes and C++ methods. Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Remove deprecated PyBufferRegion methods from _backend_agg_wrapper.cpp

4536e96

Removed `to_string` and `to_string_argb` methods from `PyBufferRegion_init_type` Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Update format of API change note

24b56c6

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

remove to_string_argb

f7c4f30

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

Update doc format

47dae23

Co-authored-by: Kyle Sunden <git@ksunden.space>

issamarabi and others added 3 commits November 2, 2023 08:30

Update doc/api/next_api_changes/removals/26962-IA.rst

ab08ae7

Update doc format Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

remove to_string_argb declaration

d631798

Signed-off-by: Issam Arabi <issam@cs.toronto.edu>

refactor

1d45c3d

issamarabi force-pushed the remove-backend-deprecations branch from 36bc45d to 1d45c3d Compare November 2, 2023 12:31

ksunden requested changes Nov 2, 2023

View reviewed changes

Comment thread doc/api/next_api_changes/removals/26962-IA.rst Outdated

Update formatting of note

75684d3

Co-authored-by: Kyle Sunden <git@ksunden.space>

QuLogic approved these changes Dec 5, 2023

View reviewed changes

ksunden approved these changes Dec 6, 2023

View reviewed changes

ksunden merged commit f80ff65 into matplotlib:main Dec 6, 2023

Remove backend 3.7-deprecated API by issamarabi · Pull Request #26962 · matplotlib/matplotlib · GitHub

Uh oh!

Remove backend 3.7-deprecated API - #26962

Remove backend 3.7-deprecated API #26962ksunden merged 14 commits intomatplotlib:mainmatplotlib/matplotlib:mainfrom issamarabi:remove-backend-deprecationsissamarabi/matplotlib:remove-backend-deprecationsCopy head branch name to clipboard

Conversation

issamarabi commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary

PR checklist

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Sep 30, 2023

Uh oh!

issamarabi commented Sep 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksunden commented Oct 9, 2023

Uh oh!

Vishnu9535 commented Oct 30, 2023

Uh oh!

QuLogic commented Oct 30, 2023

Uh oh!

timhoffm commented Nov 2, 2023

Uh oh!

issamarabi commented Nov 2, 2023

Uh oh!

ksunden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

issamarabi commented Nov 7, 2023

Uh oh!

rcomer commented Nov 29, 2023

Uh oh!

QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Dec 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Remove backend 3.7-deprecated API #26962
ksunden merged 14 commits into
matplotlib:mainfrom
issamarabi:remove-backend-deprecations

issamarabi commented Sep 29, 2023 •
edited
Loading