| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Attn @timhoffm - I moved things around so much that I figure I should check if I did anything you're opposed to. |
Sorry, something went wrong.
Thanks for the heads up. I will check later. |
Sorry, something went wrong.
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
@story645 please decide yourself whether you want to backport this. |
Sorry, something went wrong.
|
@meeseeksdev backport to v3.8-doc |
Sorry, something went wrong.
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
Sorry, something went wrong.
…d naming conventions table
|
@meeseeksdev backport to v3.8.1-doc |
Sorry, something went wrong.
…d naming conventions table
|
backported to avoid merge conflicts if smaller changes get backported 😓 |
Sorry, something went wrong.
…213-on-v3.8.x Backport PR #27213 on branch v3.8.x (DOC: consolidated coding guide and added naming conventions table)
…213-on-v3.8.1-doc Backport PR #27213 on branch v3.8.1-doc (DOC: consolidated coding guide and added naming conventions table)
| Back | FazBrowse Home | New Git URL |
This started as an attempt to document variable naming conventions to address #22156 and well trying to put a table into a bullet list didn't work well and that had me thinking that a bullet list is the wrong structure when tables are involved so 😅 this PR:
While it may not seem like it, I have tried to avoid rewording/rewriting except to remove redundancy. In particularly, I'm trying to remove duplicate sets of detailed instructions b/c I think that creates space for deviation in those instructions/confusion.
Next Steps
I think merging this should be good enough to close #26095 cause it'll at least put everything in one place (mostly). I don't want to overwhelm this PR w/ changes since it's already doing a lot more than I planned, but once this is merged I'd like to clean up the code section of the policy and guidelines page so that it can just be a TOC. To do so, I think a sensible swapping would be to
Basically proposing that the code section of policies & guidelines changes:
and the triage section changes to
or the pull request triage document gets moved to maintenance, but technically I think anyone w/ triage rights can do most of the triage stuff discussed in the pull request guide.