FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix build on PyPy by QuLogic · Pull Request #27359 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix build on PyPy - #27359

Merged
oscargus merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-pypy
Nov 23, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Fix build on PyPy#27359
oscargus merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-pypy

Conversation

QuLogic commented Nov 21, 2023

Copy link
Copy Markdown
Member

PR summary

It appears that Py_FileSystemDefaultEncodeErrors is not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built.

Since pybind11 does not have a wrapper for PyUnicode_EncodeFSDefault (the main reason I had switched to a encode call earlier), we need to call it ourselves manually.

PR checklist

Fix build on PyPy
e08cbf1 
It appears that `Py_FileSystemDefaultEncodeErrors` is not part of the
limited API, and PyPy does not have it.

Since pybind11 does not have a wrapper for `PyUnicode_EncodeFSDefault`
(the main reason I had switched to a `encode` call earlier), we need to
call it ourselves manually.
QuLogic added GUI: tk CI: Run cibuildwheel Run wheel building tests on a PR labels Nov 21, 2023
QuLogic added this to the v3.9.0 milestone Nov 21, 2023

ksunden commented Nov 21, 2023

Copy link
Copy Markdown
Member

Is this a problem only for the meson builds?

QuLogic commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

I don't think so; I forgot to mention it was caused by #26992 according to the CI logs.

ksunden commented Nov 21, 2023

Copy link
Copy Markdown
Member

Ahh, okay, I was wondering if it needed to be backported (and possibly prompt another release), but the line that is changing is only on main, so don't think so.

jklymak commented Nov 21, 2023

Copy link
Copy Markdown
Member

Should we be concerned that this has no test coverage?

QuLogic commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

That is definitely wrong; we probably lost coverage for compiled code in the move to Meson.

QuLogic commented Nov 22, 2023

Copy link
Copy Markdown
Member Author

Looking at the coverage for the file directly, it's not really uncovered, but partially covered. This probably partially because we don't do coverage on non-Linux, but I'm investigating some outdated settings in the test config.

oscargus merged commit 0a4efbe into matplotlib:main Nov 23, 2023
QuLogic deleted the fix-pypy branch November 23, 2023 20:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
ksunden ksunden approved these changes

Assignees

No one assigned

Labels

CI: Run cibuildwheel Run wheel building tests on a PR GUI: tk

Projects

None yet

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL