Repository navigation
Added test for tricontour in test_datetime.py - #27494
maryamyounis wants to merge 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
ksunden
left a comment
There was a problem hiding this comment.
Thank you for finding this.
It is actually the the goal of doing this exercise to find the places where we think we should support unitful behavior but do not.
It appears that actually current main does not error but also doesn't behave correctly either when handed (at least numpy datetime64 arrays) datetimes. I've opened #27499 to track this problem (along with the other tri* methods)
I will block merging this until the underlying problems are addressed.
Sorry, something went wrong.
| def test_tricontourf(self): | ||
| fig, ax = plt.subplots() | ||
| ax.tricontourf(...) | ||
| def test_tricontour(self): |
There was a problem hiding this comment.
It looks like you wrote the test for tricontour (the unfilled variant), but deleted the stub for tricontourf (the filled variant)
Sorry, something went wrong.
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the status: autoclose candidate label and the PR stays open. Cosmetic changes or incomplete fixes will not be sufficient. Maintainers will assess improvements on their own schedule. Please do not ping (@) maintainers. |
Sorry, something went wrong.
|
Thank you for your interest in contributing to Matplotlib, but we cannot accept your contribution as this pull request does not meet our development standards. Following our review policy, we are closing this PR after allowing two weeks time for improvements. Thank you for your understanding. If you think your PR has been closed by mistake, please comment below. |
Sorry, something went wrong.
PR summary
This PR addresses the tricontour task in the Increase Unit Test Coverage Issue: #26864.
PR checklist