Repository navigation
Best-legend-location microoptimization - #27517
Merged
ksunden merged 1 commit intoDec 19, 2023
Merged
ksunden merged 1 commit into
ksunden merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
QuLogic
approved these changes
Dec 15, 2023
timhoffm
reviewed
Dec 15, 2023
Comment thread
lib/matplotlib/legend.py
Outdated
oscargus
marked this pull request as draft
December 15, 2023 16:22
oscargus
force-pushed
the
bestlegendsubopt
branch
from
f62d909 to
b986f60
Compare
December 17, 2023 14:18
oscargus
marked this pull request as ready for review
December 17, 2023 14:48
ksunden
approved these changes
Dec 19, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Best legend location is slow as it is. May just as well avoid additional list allocations where possible.
PR checklist