FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve Locator docstrings by dstansby · Pull Request #27686 · matplotlib/matplotlib · GitHub

/ matplotlib Public

Improve Locator docstrings - #27686

Merged
dstansby merged 2 commits into
matplotlib:mainfrom
dstansby:locator-docstrings
Jan 30, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Improve Locator docstrings#27686
dstansby merged 2 commits into
matplotlib:mainfrom
dstansby:locator-docstrings

Conversation

dstansby commented Jan 22, 2024

Copy link
Copy Markdown
Member

PR summary

Improves Locator docstrings by adding a single sentence at the beginning of each docstring in a consistent style.

PR checklist

dstansby added the Documentation: API files in lib/ and doc/api label Jan 22, 2024
story645 requested changes Jan 22, 2024
View reviewed changes

story645 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Like the uniformity a lot, but think Places/positions ticks would be clearer.

Everything else is mostly various shades of small comments.

Also 🤦‍♀️ and apologies if draft meant this wasn't ready for review.

Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
dstansby marked this pull request as ready for review January 23, 2024 09:35

dstansby commented Jan 23, 2024

Copy link
Copy Markdown
Member Author

Also 🤦‍♀️ and apologies if draft meant this wasn't ready for review.

No a review is very welcome 😄 - I tend to open PRs in draft until the CI passes just in case.

story645 approved these changes Jan 24, 2024
View reviewed changes

story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

mostly nits, but maybe linearly spaced->evenly spaced for clarity?

Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
Comment thread lib/matplotlib/ticker.py Outdated
github-actions Bot removed the Documentation: API files in lib/ and doc/api label Jan 30, 2024
story645 added this to the v3.9.0 milestone Jan 30, 2024
story645 added the Documentation: API files in lib/ and doc/api label Jan 30, 2024

story645 commented Jan 30, 2024

Copy link
Copy Markdown
Member

Can I squash merge (or you can squash merge) or do you want to rebase?

dstansby merged commit d3144b1 into matplotlib:main Jan 30, 2024

dstansby commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

👍 to squash merging

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic left review comments
story645 story645 approved these changes

Assignees

No one assigned

Labels

Documentation: API files in lib/ and doc/api topic: ticks axis labels

Projects

None yet

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL