Repository navigation
Add warning for multiple pyplot.figure calls with same ID - #27992
Merged
timhoffm merged 5 commits intoMay 19, 2024
Merged
timhoffm merged 5 commits into
timhoffm merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timhoffm
approved these changes
Apr 3, 2024
tacaswell
reviewed
May 8, 2024
Comment thread
lib/matplotlib/tests/test_pyplot.py
Outdated
Copy link
Copy Markdown
Member
|
It looks like appveyor failed trying to install the codecov uploader. |
Sorry, something went wrong.
tacaswell
approved these changes
May 13, 2024
Copy link
Copy Markdown
Member
|
The test failures looked unrelated, re-running. |
Sorry, something went wrong.
Impaler343
force-pushed
the
figure-warning
branch
2 times, most recently
from
c8e7a8e to
f36cdcf
Compare
May 19, 2024 09:34
Exclude the 'clear' argument
Made test more versatile
Impaler343
force-pushed
the
figure-warning
branch
from
f36cdcf to
18eb3e7
Compare
May 19, 2024 09:49
tacaswell
reviewed
May 19, 2024
Comment thread
lib/matplotlib/pyplot.py
Copy link
Copy Markdown
Member
|
Failing tests are unrelated. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #27978. This hopefully adds the relevant warning discussed in the issue
PR checklist