| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I don't know why docs and CI are failing, could somebody please check this out? |
Sorry, something went wrong.
|
Hi @Impaler343, I'm not certain but I think the docs failure may be related to something that has been fixed on main. Could you try rebasing? git fetch upstream git rebase upstream/main Appveyor is showing the same failure on all PRs right now, so I wouldn't worry about that one. |
Sorry, something went wrong.
|
Do I also need to squash? |
Sorry, something went wrong.
|
There is enough exploration/experimentation in here it is probably worth squashing to a handful of commits. |
Sorry, something went wrong.
|
I think this is like 80% of the way there and looking pretty good! |
Sorry, something went wrong.
|
Can we get a feature for check_figures_equal() similar to image_comparison()'s remove_text feature? As the former is a more economical way to test, having it for check_figures_equal() would be a good idea. Or is it already available, and I don't see it? |
Sorry, something went wrong.
I do not think this is required? The reason remove_text exists is that the font files may be different on different machine. However, check_figures_equal() are executed on the same machine, so should never be a problem. Am I missing something? |
Sorry, something went wrong.
I suggested this as it is a quick plugin to make tests run faster by focussing on the important part of the plot, by removing axes, labels and ticks, and this most probably should make a significant difference while running a large amount of tests |
Sorry, something went wrong.
Problems were introduced by matplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
Problems were introduced by matplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
Problems were introduced by matplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
| Back | FazBrowse Home | New Git URL |
PR summary
Fixes #21108 using the patch provided by @anntzer which I modified to pass tests. Need to write tests for:
PR checklist