Repository navigation
Add compilers to conda environment - #28352
tacaswell merged 2 commits into
Conversation
Sorry, something went wrong.
|
Anyone can merge when green. |
Sorry, something went wrong.
|
Are CodeCov or AppVeyor relevant here? Mentioning as those appear to be the only failures |
Sorry, something went wrong.
|
Unfortunately, yes. We use the environment file on appveyor |
Sorry, something went wrong.
|
The error on AppVeyor suggests the compiler is not on the path ..\..\meson.build:1:0: ERROR: Unknown compiler(s): [['cl.exe']] The following exception(s) were encountered: Running `cl.exe /?` gave "[WinError 2] The system cannot find the file specified" Edit: When we used AppVeyor in conda-forge in the past, we would typically add a line like this to activate the compiler. Am not seeing that line in the AppVeyor configuration file in this repo, but maybe I'm missing it? call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" amd64 |
Sorry, something went wrong.
|
Originally, we told Meson to enable the MSVC environment automatically; this was because AppVeyor had Strawberry Perl with its totally broken compilers on the path first. It seems that adding compilers from conda-forge causes MSVC to be hidden entirely, but that's sort of what we want anyway. I'll remove the --vsenv flag so that AppVeyor uses the conda compilers. We test MSVC on Azure, so we aren't losing anything by that change. |
Sorry, something went wrong.
This fixes issues with `libstdc++.so` when using a system with a newer compiler. In such cases, the compiler will create links to new symbols, but the shared library available at runtime from conda-forge will not have them available. This results in errors such as: ``` ImportError: /home/elliott/micromamba/envs/mpl-dev/bin/../lib/libstdc++.so.6: version `CXXABI_1.3.15' not found (required by /home/elliott/code/matplotlib/build/cp39/src/_c_internal_utils.cpython-39-x86_64-linux-gnu.so) ```
|
FWIW we now have pikepdf in conda-forge (think we were just missing Windows before) Line 48 in 54729db |
Sorry, something went wrong.
|
All seems to be working now - just in case I'm missing something I'll let this sit for a few days, but if no-one objects after that I'll merge. |
Sorry, something went wrong.
PR summary
This fixes issues with libstdc++.so when using a system with a newer compiler. In such cases, the compiler will create links to new symbols, but the shared library available at runtime from conda-forge will not have them available.
This results in errors such as:
I'm fairly certain we have seen similar issues here or on Gitter, but am not aware of one at the moment.
@jakirkham also suggested adding python even if we don't pin it just to be explicit.
PR checklist