FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: Fix version switcher for stable docs by QuLogic · Pull Request #28512 · matplotlib/matplotlib · GitHub

Repository navigation

DOC: Fix version switcher for stable docs - #28512

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-stable
Jul 6, 2024
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-stable

Conversation

QuLogic commented Jul 5, 2024

Copy link
Copy Markdown
Member

PR summary

This should stop the banner from showing up on stable.

PR checklist

This should stop the banner from showing up on stable.

story645 commented Jul 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Is this what's supposed to be fixed? And can it only be fixed after merging? This is taken from the artifacts job on this PR:

QuLogic commented Jul 5, 2024

Copy link
Copy Markdown
Member Author

Yea, it won't be fixed until merged, as everything pulls that json file from devdocs.

story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not merging cause I'm confused how merging to main fixes issues w/ 3.9 docs - is this supposed to be backported-but I figure @QuLogic knows the answer to this.

QuLogic commented Jul 6, 2024

Copy link
Copy Markdown
Member Author

All docs pull switcher.json from devdocs; there's no need to backport. The version just needs to match.

QuLogic merged commit 9f31b01 into matplotlib:main Jul 6, 2024
QuLogic added this to the v3.10.0 milestone Jul 6, 2024
QuLogic deleted the fix-stable branch July 6, 2024 05:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL