Repository navigation
DOC: Standardize example titles - #28544
Merged
timhoffm merged 1 commit intoJul 27, 2024
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
story645
reviewed
Jul 23, 2024
story645
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for doing such a large batch! Small comments on a couple of titles, I hope.
Sorry, something went wrong.
Comment thread
galleries/examples/animation/unchained.py
| MATPLOTLIB **UNCHAINED** | ||
| ======================== | ||
| ==================== | ||
| Matplotlib unchained |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is fun and not at all descriptive :/
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I have no better name and don't know if anybody feels strongly about this particular title. So I've just removed the special formatting.
Sorry, something went wrong.
Comment thread
galleries/examples/axes_grid1/scatter_hist_locatable_axes.py
Outdated
Comment thread
galleries/examples/event_handling/zoom_window.py
| Zoom Window | ||
| =========== | ||
| ======================== | ||
| Zoom modifies other Axes |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
would folks recognize `brushing-linking w/ zoom" or too jargony?
If jargony, then this brush-link should be added in tags at some point and maybe in the discription
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
"brushing-linking" does not tell me anything :/
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
sounds like it's a good candidate for a tag then, rather than a title. https://infovis-wiki.net/wiki/Linking_and_Brushing
Sorry, something went wrong.
Comment thread
galleries/examples/lines_bars_and_markers/scatter_masked.py
Outdated
Comment thread
galleries/examples/lines_bars_and_markers/simple_plot.py
Outdated
Comment thread
galleries/examples/text_labels_and_annotations/custom_legends.py
Outdated
Comment thread
galleries/examples/text_labels_and_annotations/text_commands.py
Outdated
Comment thread
galleries/examples/text_labels_and_annotations/text_rotation_relative_to_line.py
Outdated
Comment thread
galleries/examples/text_labels_and_annotations/usetex_baseline_test.py
Outdated
Comment thread
galleries/examples/widgets/range_slider.py
Outdated
timhoffm
commented
Jul 25, 2024
Comment thread
galleries/examples/event_handling/zoom_window.py
| Zoom Window | ||
| =========== | ||
| ======================== | ||
| Zoom modifies other Axes |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
"brushing-linking" does not tell me anything :/
Sorry, something went wrong.
Comment thread
galleries/examples/axes_grid1/scatter_hist_locatable_axes.py
Outdated
Comment thread
galleries/examples/lines_bars_and_markers/scatter_masked.py
Outdated
timhoffm
force-pushed
the
doc-example-titles
branch
from
397c0a1 to
4a64f04
Compare
July 25, 2024 18:33
story645
approved these changes
Jul 25, 2024
Copy link
Copy Markdown
Member
|
Can self merge after rebase and working doc build. |
Sorry, something went wrong.
Following recommendatinos from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups. Co-authored-by: hannah <story645@gmail.com>
timhoffm
force-pushed
the
doc-example-titles
branch
from
4a64f04 to
eecc0a0
Compare
July 27, 2024 21:03
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 1, 2024
Follow up to matplotlib#28544. As there: Following recommendations from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 1, 2024
Follow up to matplotlib#28544. As there: Following recommendations from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 1, 2024
Follow up to matplotlib#28544. As there: Following recommendations from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 1, 2024
Follow up to matplotlib#28544. As there: Following recommendations from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 2, 2024
Follow up to matplotlib#28544. As there: Following recommendations from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 2, 2024
Follow up to matplotlib#28544. As there: Following recommendations from matplotlib#28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw t a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups. Co-authored-by: hannah <story645@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following recommendatinos from #28527, this improves example titles. Take this as an incremental improvement. I've changed what I saw at a glance when going through the examples once. Certainly, one could do further improvements, but that can be done in follow-ups.