Repository navigation
Fix MSVC cast warnings - #28967
Merged
ianthomas23 merged 4 commits intoOct 25, 2024
Merged
Fix MSVC cast warnings#28967ianthomas23 merged 4 commits into
ianthomas23 merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I see one more on AppVeyor to fix: [80/97] Compiling C++ object src/ft2font.cp311-win_amd64.pyd.p/ft2font_wrapper.cpp.obj ../../src/ft2font_wrapper.cpp(964): warning C4244: 'argument': conversion from 'double' to 'int', possible loss of data ../../src/ft2font_wrapper.cpp(964): warning C4244: 'argument': conversion from 'double' to 'int', possible loss of data |
Sorry, something went wrong.
These were silently truncated to int anyway, so we should make the types explicit.
The Agg API uses `double`s here, but the array sizes are `pybind11::ssize_t`, which are technically bigger (in some ways), and cause a warning on MSVC. We don't accept a backing surface larger than ~2^24, so there's no worry about these overflowing.
Its only use was removed in 193e5a9.
These were silently truncated to int anyway, so we should make the types explicit.
Copy link
Copy Markdown
Member
Author
|
AppVeyor and Azure Windows builds are now warning free. |
Sorry, something went wrong.
QuLogic
marked this pull request as ready for review
October 24, 2024 22:54
tacaswell
approved these changes
Oct 25, 2024
ianthomas23
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
MSVC on the Azure/AppVeyor builds currently produce a few warnings. These are due to some lax input types, or otherwise because of differing type sizes on Windows. The values are generally not in the range where it would matter, so we can make the casts explicit to silence the warnings.
For the incorrect types, the old types are deprecated, but still accepted.
This is based on #28842 at the moment due to conflicting changes, but the last four commits are the relevant ones here.
PR checklist