Repository navigation
FIX: zero width lines need no pattern - #29302
rcomer wants to merge 1 commit into
Conversation
Sorry, something went wrong.
| c.set_linewidth(0) | ||
|
|
||
| # With a zero linewidth, there can be no pattern | ||
| assert c.get_linestyle() == [(0, None)] |
There was a problem hiding this comment.
Note that "solid" results in [('', None)] instead which I believe is incorrect wrt. to the declared type.
We are overall not consistent and clear what get_linestyle() means:
- for Line2D.get_linestyle() it is always a str, and if given a dash pattern, the result is "--".
- for Patch.get_linestyle(), we basically get what we put in str or (unscaled) dash pattern; with the exception of normalizing "no style" ' ', '', 'none' to "None"
- for Collections, we always get a scaled dash pattern.
While this fix may be ok as a workaround to fix the original issue (and doesn't make the consisteny worse), we should generally agee upon what get_linestyle() means - and a scaled dash pattern would be the last of my choices.
Sorry, something went wrong.
There was a problem hiding this comment.
Actually looking closer, I don't think the legend handler should be getting the scaled pattern - it gets scaled again on the patch, so is wrong for any linewidth != 1.
I'll close this.
Sorry, something went wrong.
PR summary
Proposal to fix #28298. If the linewidth is zero then the dash pattern is arbitrary, so set the scaled pattern to None, which is the same as solid lines.
PR checklist