Repository navigation
FIX: pass renderer through _auto_legend_data - #29317
Merged
timhoffm merged 1 commit intoDec 16, 2024
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
oscargus
approved these changes
Dec 16, 2024
oscargus
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice test! (I would have went with an image test, but this is clearly better!)
Sorry, something went wrong.
timhoffm
approved these changes
Dec 16, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 16, 2024
rcomer
added a commit
that referenced
this pull request
Dec 16, 2024
…317-on-v3.10.x Backport PR #29317 on branch v3.10.x (FIX: pass renderer through `_auto_legend_data`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #29301.
The problem was that FigureCanvasPS._print_figure essentially got into a loop of calling itself: somewhere within figure.draw we needed to call figure._get_renderer in order to calculate the annotation window extent and therefore the legend position. _get_renderer ultimately calls FigureCanvasPS._print_figure again. I haven't quite followed why, but by the time we get to the end of FigureCanvasPS._print_figure, _ps_writer which should contain all the information about the artists is empty.
We can avoid all this by just passing the renderer we already have hold of to get_window_extent.
PR checklist