Repository navigation
fix #29410 Modifying Axes' position also alters the original Bbox object used for initialization - #29411
Merged
timhoffm merged 2 commits intoJan 10, 2025
Merged
fix #29410 Modifying Axes' position also alters the original Bbox object used for initialization#29411timhoffm merged 2 commits into
timhoffm merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
tacaswell
reviewed
Jan 9, 2025
Comment thread
lib/matplotlib/tests/test_axes.py
Outdated
Copy link
Copy Markdown
Member
|
"power cycled" the PR to pick up the fix for py310. |
Sorry, something went wrong.
tacaswell
approved these changes
Jan 10, 2025
timhoffm
approved these changes
Jan 10, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 10, 2025
…sition also alters the original Bbox object used for initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR fix #29410 Modifying Axes' position also alters the original Bbox object used for initialization.
Making a copy of the reference Bbox using its .frozen() method solves the problem.
PR checklist