FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BUG : turned clipping off on pie chart components by tacaswell · Pull Request #2952 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

BUG : turned clipping off on pie chart components - #2952

Merged
WeatherGod merged 1 commit into
matplotlib:masterfrom
tacaswell:pie_clipping
Jul 6, 2014
ConversationCommits (1)ChecksFiles changed
Merged

BUG : turned clipping off on pie chart components#2952
WeatherGod merged 1 commit into
matplotlib:masterfrom
tacaswell:pie_clipping

Conversation

tacaswell commented Apr 3, 2014

Copy link
Copy Markdown
Member

closes #2518

This should probably get a test, https://stackoverflow.com/questions/19347453/matplotlib-savefig-trims-the-graph should be a good base.

tacaswell added this to the v1.4.0 milestone Apr 3, 2014

Tillsten commented Apr 5, 2014

Copy link
Copy Markdown
Contributor

Could you maybe explain why this is better than just adjust the hardcoded limits by a small amount?
Else this patch is fine. Thanks for your hard work, @tacaswell.

tacaswell commented Apr 7, 2014

Copy link
Copy Markdown
Member Author

I think this is better than adjusting the limits because now the patches and the text match clipping behavior. It would be better to control this via kwarg (not hard coded) for both the text and the wedges. I will take care of that when I rebase.

tacaswell commented Apr 17, 2014

Copy link
Copy Markdown
Member Author

@Tillsten Changed to leveraging the newly added *props dicts.

Tillsten commented Apr 23, 2014

Copy link
Copy Markdown
Contributor

Could you also link the PR where the dict was added? Still one question left (see commit coment). If the answer is no, LGTM. Thanks again for you work!

tacaswell commented Apr 23, 2014

Copy link
Copy Markdown
Member Author

The dicts were added in #2923

Tillsten commented Apr 24, 2014

Copy link
Copy Markdown
Contributor

You are right, it copys the props, so LGTM from me.

BUG : turned clipping off on pie chart components
89d8ac8 
 - set default value of `clip_on` in *prop dicts
 - closes matplotlib#2518
WeatherGod added a commit that referenced this pull request Jul 6, 2014
Merge pull request #2952 from tacaswell/pie_clipping
fa86275 
BUG : turned clipping off on pie chart components
WeatherGod merged commit fa86275 into matplotlib:master Jul 6, 2014
tacaswell deleted the pie_clipping branch July 6, 2014 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

pie chart is trimmed

4 participants

Back | FazBrowse Home | New Git URL