FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: add color sequences reference example by rcomer · Pull Request #29563 · matplotlib/matplotlib · GitHub

Repository navigation

DOC: add color sequences reference example - #29563

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
rcomer:doc-color-sequences
Feb 2, 2025
Merged

timhoffm merged 1 commit into
matplotlib:mainfrom
rcomer:doc-color-sequences

Conversation

rcomer commented Feb 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

PR summary

Introducing the Matplotlib Abacus!

I did not know that the color sequence registry was a thing. Once I did know, the next thing I wanted to know was what sequences are available. This PR adds an example showing all the built in sequences, analogous to the Colormaps reference and List of Named Colors.

I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.

PR checklist

rcomer commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

New example

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like the style.

I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.

You can add a sentence that users can register their own sequences as well and point to register. IMHO an example is not too helpful here. The concept "register -> you can query it by name" is straigt forward. The plot itself will not be helpful as you cannot visualize "there's a new element in the registry". That can only be inferred from the associated example code. But as said, the concept is so simple that any example is dilluting the message because of the additional visualization code.

rcomer force-pushed the doc-color-sequences branch from c2ae704 to 20d1900 Compare February 1, 2025 17:55

rcomer commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

Did there used to be a Dark1?

rcomer force-pushed the doc-color-sequences branch from 20d1900 to ae1359e Compare February 1, 2025 18:03

rcomer commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

Updated new example

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor style suggestions.

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Take or leave the suggestions.

rcomer force-pushed the doc-color-sequences branch from 8f08300 to c0cd916 Compare February 2, 2025 08:15
timhoffm added this to the v3.10.1 milestone Feb 2, 2025
timhoffm merged commit dd8dbca into matplotlib:main Feb 2, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 2, 2025
rcomer deleted the doc-color-sequences branch February 2, 2025 16:51
timhoffm added a commit that referenced this pull request Feb 2, 2025
…563-on-v3.10.x

Backport PR #29563 on branch v3.10.x (DOC: add color sequences reference example)
ksunden mentioned this pull request Mar 3, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL