Repository navigation
Feature: Added setter/getter methods for missing kwargs in Figure.__init__ - #29638
slightnacl wants to merge 2 commits into
Conversation
Sorry, something went wrong.
…nit__ This seeks to solve the problem outlined in issue matplotlib#24617, where there where setter/getter methods available for fig.set() that were not available on Figure(). This change adds setters and getters for both thefigsize parameter and the subplotpars parameter. Tests were also included in the testing directory under figure.py to verify the addition and functionality of the methods.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
|
We discussed issue #24617 in the weekly meeting yesterday, and the general opinion is that this issue needs refinement before it's actually actionable. For this reason, I will close all related open issues for now. This does not mean you can't open another PR in the future or that your solution is necessarily innapropriate, but this will help us focus our efforts. Thank you for your contribution and hope to see you around! |
Sorry, something went wrong.
This seeks to solve the problem outlined in issue #24617, where there where setter/getter methods available for fig.set() that were not available on Figure(). This change adds setters and getters for both thefigsize parameter and the subplotpars parameter.
Tests were also included in the testing directory under figure.py to verify the addition and functionality of the methods.