Repository navigation
DOC: change marginal scatter plot to subplot_mosaic - #29670
timhoffm merged 2 commits into
Conversation
Sorry, something went wrong.
timhoffm
left a comment
There was a problem hiding this comment.
Additional note: The examples seems to be more about subplots and placements rather than lines bars and markers. I propose to move this to the "Subplots, Axes and figures" section. Here or in a followup PR.
Sorry, something went wrong.
For sure could do that - I think the original motivation was to show folks how to make this relatively common plot type, so having it here lets them see that its possible, though of course the only "hard" thing about it is the axes layout. I could see the case for going in either direction. |
Sorry, something went wrong.
| # | ||
| # While we recommend using one of the two methods described above, there are | ||
| # number of other ways to achieve a similar layout: | ||
| # - The Axes can be positioned manually in relative coordinates using |
There was a problem hiding this comment.
| # - The Axes can be positioned manually in relative coordinates using | |
| # | |
| # - The Axes can be positioned manually in relative coordinates using |
Sorry, overlooked one additional ReST formatting issue (bullet lists must be separated with an empty line)
Sorry, something went wrong.
| # | ||
| # - `matplotlib.figure.Figure.add_subplot` | ||
| # - `matplotlib.figure.Figure.subplot_mosaic` | ||
| # - `matplotlib.figure.Figure.add_gridspec` |
There was a problem hiding this comment.
| # - `matplotlib.figure.Figure.add_gridspec` |
No longer used in the example.
Sorry, something went wrong.
There was a problem hiding this comment.
replaced with add_subplot also added pyplot.subplot_mosaic because that is more relevant.
# - `matplotlib.figure.Figure.subplot_mosaic` # - `matplotlib.pyplot.subplot_mosaic` # - `matplotlib.figure.Figure.add_subplot` # - `matplotlib.axes.Axes.inset_axes` # - `matplotlib.axes.Axes.scatter` # - `matplotlib.axes.Axes.hist`
Sorry, something went wrong.
| While `.Axes.inset_axes` may be a bit more complex, it allows correct handling | ||
| of main Axes with a fixed aspect ratio. |
There was a problem hiding this comment.
| While `.Axes.inset_axes` may be a bit more complex, it allows correct handling | |
| of main Axes with a fixed aspect ratio. |
Optional, but could be left out. That is also explained at the start of the inset_axes example itself.
Sorry, something went wrong.
There was a problem hiding this comment.
I guess I think it is also useful to explain why there are two methods where they are listed. A bit of repetition is probably OK.
Sorry, something went wrong.
…670-on-v3.10.x Backport PR #29670 on branch v3.10.x (DOC: change marginal scatter plot to subplot_mosaic)
…670-on-v3.10.0-doc Backport PR #29670 on branch v3.10.0-doc (DOC: change marginal scatter plot to subplot_mosaic)
…t-of-pr-29670-on-v3.10.0-doc Backport PR matplotlib#29670 on branch v3.10.0-doc (DOC: change marginal scatter plot to subplot_mosaic)
Follow up to #29667 to use subplot_mosaic instead of add_gridspec and three add_subplot calls.
I actually removed the gridspec example, though happy to revert and put at the end. I don't think users in general should ever need to use gridspec.