FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MultiNorm class by trygvrad · Pull Request #29876 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

MultiNorm class - #29876

Merged
QuLogic merged 19 commits into
matplotlib:mainfrom
trygvrad:multivariate-plot-prapare
Aug 20, 2025
ConversationCommits (19)ChecksFiles changed
Merged

MultiNorm class#29876
QuLogic merged 19 commits into
matplotlib:mainfrom
trygvrad:multivariate-plot-prapare

Conversation

trygvrad commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

PR summary

This PR continues the work of #28658 and #28454, aiming to close #14168. (Feature request: Bivariate colormapping)

This is part one of the former PR, #29221. Please see #29221 for the previous discussion

Features included in this PR:

  • A MultiNorm class. This is a subclass of colors.Normalize and holds n_variate norms.
  • Testing of the MultiNorm class

Features not included in this PR:

  • changes to colorizer.py needed to expose the MultiNorm class
  • Exposes the functionality provided by MultiNorm together with BivarColormap and MultivarColormap to the plotting functions axes.imshow(...), axes.pcolor, and `axes.pcolormesh(...)
  • Testing of the new plotting methods
  • Examples in the docs

This was referenced Apr 6, 2025
Closed
Closed
oscargus reviewed Apr 6, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
oscargus reviewed Apr 6, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
oscargus reviewed Apr 6, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed Apr 7, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed Apr 7, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed Apr 7, 2025
View reviewed changes
Comment thread lib/matplotlib/scale.py Outdated
QuLogic reviewed Apr 17, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.pyi Outdated
Comment thread lib/matplotlib/colors.pyi Outdated
trygvrad force-pushed the multivariate-plot-prapare branch from 55b85e3 to f42d65b Compare April 17, 2025 15:18
anntzer reviewed May 1, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed May 1, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed May 1, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed May 1, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
anntzer reviewed May 1, 2025
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just some minor points, plus re-pinging @timhoffm in case he has an opinion re: n_input / input_dims naming?

ghost commented May 4, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for the feedback @anntzer !
Hopefully we can hear if @timhoffm has any thoughts on n_input / input_dims naming within the coming week.

ghost commented May 5, 2025

Copy link
Copy Markdown
Member

See #29876 (comment)

ghost commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @timhoffm
The PR should now be as we agreed (#29876 (comment)) :)

QuLogic reviewed May 23, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py

ghost commented Jun 1, 2025

Copy link
Copy Markdown
Contributor Author

@QuLogic Thank you again and apologies for my tardiness (I was sick)
@timhoffm Do you think you could approve this PR now?

timhoffm reviewed Jun 2, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py
Comment thread lib/matplotlib/colors.py Outdated
QuLogic reviewed Jun 4, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
trygvrad force-pushed the multivariate-plot-prapare branch from 6b86d63 to 32247f5 Compare June 4, 2025 21:01
trygvrad mentioned this pull request Jun 6, 2025
Closed

ghost commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

This is on hold until we sort out #30149 (Norm Protocol)
see #29876 (comment)

trygvrad mentioned this pull request Jun 15, 2025
Merged

ghost commented Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

I changed vmin, vmax and clip to only accept iterables or None.

It dawned on me that it will be useful to allow None, with the behavior that it does not modify the vmin/vmax/clip on the constituent norms. This will be useful for use as a default, but also be useful for users that want to combine multiple norms into a MultiNorm without modifying the limits of the norms.

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

timhoffm reviewed Aug 1, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated

ghost commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

Sorry I dropped the ball on this. I can try to have a look but not before the middle of the month or so.

QuLogic reviewed Aug 7, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.pyi Outdated
Apply suggestions from code review
f61c06b 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
trygvrad force-pushed the multivariate-plot-prapare branch from ff2eb20 to f61c06b Compare August 7, 2025 21:25

ghost commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

ghost commented Aug 15, 2025

Copy link
Copy Markdown
Member

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

There are still a couple of comments that are unresolved/have no reply, at least.

ghost commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

@QuLogic @story645 thank you for your comments and patience on this, I believe i have addressed all the comments now, but please correct me again if there are some I have overlooked. Otherwise I look forward to your future comments :)

QuLogic reviewed Aug 16, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/tests/test_colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
QuLogic reviewed Aug 16, 2025
View reviewed changes
Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.py Outdated
Apply suggestions from code review
3267fe9 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
trygvrad force-pushed the multivariate-plot-prapare branch from 486a58f to 3267fe9 Compare August 16, 2025 20:42
QuLogic added this to the v3.11.0 milestone Aug 19, 2025
QuLogic reviewed Aug 20, 2025
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a minor last thing,

Comment thread lib/matplotlib/colors.py Outdated
Comment thread lib/matplotlib/colors.pyi Outdated

ghost commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Just a minor last thing,

Thank you @QuLogic !

QuLogic approved these changes Aug 20, 2025
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Were you expecting a squash merge?

ghost commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Were you expecting a squash merge?

Yes, I believe a squash merge would be most suitable

QuLogic merged commit 3a8ad1d into matplotlib:main Aug 20, 2025

ghost commented Aug 20, 2025

Copy link
Copy Markdown
Member

Thanks for working your way through this long process.

Migelo mentioned this pull request Aug 21, 2025
Merged
This was referenced Aug 25, 2025
Merged
Merged
trygvrad mentioned this pull request Sep 3, 2025
Merged
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

story645 story645 left review comments
anntzer anntzer left review comments
jklymak jklymak left review comments
timhoffm timhoffm approved these changes
oscargus oscargus left review comments
QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

Documentation: API files in lib/ and doc/api topic: color/color & colormaps

Projects

Bivariate and Multivariate Colormapping
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Feature request: Bivariate colormapping

7 participants

Back | FazBrowse Home | New Git URL