The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps by useidemaisachola · Pull Request #29895 · matplotlib/matplotlib · GitHub

PR summary

-This change was necessary to resolve a bug: Fixes #29780
-Color of errorbar caps now it's not affected by 'lines.markeredgecolor'.

The reason behind the implementation is as follows:
The initial issue arose when the caps of the error bars were unintentionally adopting the color red, which was set globally in mpl.rcParams under the 'lines.markeredgecolor' parameter. This global setting was being applied to all markers, including the caps of error bars, causing the caps to appear red even when that wasn't intended.
The root cause of the problem was that the marker edge color defined globally (mpl.rcParams['lines.markeredgecolor']) was being inherited by the caps as part of the error bar plot. This caused the color of the caps to match the global red color, even when only the error bars were supposed to be red (through the ecolor parameter).
To solve this, we needed to ensure that the caps would use the specified ecolor independently of the global mpl.rcParams['lines.markeredgecolor']. This was achieved by setting the marker edge color for the caps separately, rather than relying on the global configuration.
The files that suffered alterations were _axes.py and test_axes.py.

PR checklist

[ N/A] "closes #0000" is in the body of the PR description to link the related issue
new and changed code is tested
[ N/A] Plotting related features are demonstrated in an example
[N/A ] New Features and API Changes are noted with a directive and release note
[N/A ] Documentation complies with general and docstring guidelines

…olor To solve this, we needed to ensure that the caps would use the specified ecolor independently of the global mpl.rcParams['lines.markeredgecolor']. This was achieved by setting the marker edge color for the caps separately, rather than relying on the global configuration.

The default value of lines.markeredgecolor 'auto' which means "follow the color", but when setting it to a color it stops following the color of the line.

This is the correct fix.

@useidemaisachola Thank you for this fix and the test! If you can clean up the linting/whitespace issues I think this can be merged straight away.

@tacaswell ok, i can solve them! One question as this is my first PR - after i resolve the problems with the spaces i have to commit and open another PR? Or it's possible to still use this one?

You should continue on your branch, and pushing it here will update this PR.

@QuLogic Ok, thank you!

@tacaswell I resolved the problem with the spaces! Now it's giving some kind of error with the version of python on windows... It is something that i have to change?

@useidemaisachola that Azure Windows test can be flakey. The failure is not caused by your change. I have re-run it to see if we can be lucky the second time.

so, now i have to resolve the conflits?

so, now i have to resolve the conflits?

Yes, but if you are not comfortable doing that we can handle it for you. It looks like you and and another recent PR have added new tests in the same place, so it's just a case of making sure we keep both.

Already resolved the conflit but I guess i leaved an extra line at the end of the file or something like that, because it's failing one test... it's that?

I took the liberty to remove the extra line at the end. Tests should pass now.

As above:

Suggested change

      
                y = np.sin(x)
          
                yerr = 0.1
          
                mpl.rcParams['lines.markeredgecolor'] = 'green'
          
                fig, ax = plt.subplots()
          
                errorbars = ax.errorbar(x, y, yerr=yerr, fmt='o', capsize=5)
          
                mpl.rcParams['lines.markeredgecolor'] = 'green'
          
                fig, ax = plt.subplots()
          
                errorbars = ax.errorbar(x, np.sin(x), yerr=0.1)

ok, thank you for the tips and the help!

I have to enter the suggestion that you told me or it´s already changed in the repository?

You'll have to apply it yourself, either locally and push, or using the UI here.

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

ok, it gave an error but I will fix it.

I think everything it´s ok now.

Now i have to do close or something like that?

No. You don't have to do anything. We have policy that each PR needs two approvals by core developers. So, we're just waiting for a second review.

Ok, thank you.

Thanks @useidemaisachola! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

git checkout v3.10.x
git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 20bdd72d3cb9a4a93657091d80fdeb9d0089609c

You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am "Backport PR #29895: The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps "

Push to a named branch:

git push YOURFORK v3.10.x:auto-backport-of-pr-29895-on-v3.10.x

Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR #29895 on branch v3.10.x (The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps )"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic Thank you so much! So can I delete already the branch? The lumberbot gave some kind of feedback...

@useidemaisachola you can safely delete your branch. Your work is now in Matplotlib's main branch and lumberbot is here to help us get it also into our v3.10.x branch (which we will use for the next micro release).
https://matplotlib.org/devdocs/devel/pr_guide.html#backport-strategy

Ok, thank you!

… interfere on the color of errorbar caps

…3.10.x Backport PR #29895 on branch v3.10.x (The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps)"

… interfere on the color of errorbar caps

useidemaisachola added 3 commits March 28, 2025 13:14

Merge branch 'matplotlib:main' into bugfix-for-issue-29780

9b98c7f

Merge branch 'matplotlib:main' into bugfix-for-issue-29780

746a096

tacaswell added this to the v3.10.2 milestone Apr 11, 2025

useidemaisachola added 2 commits April 19, 2025 12:35

Merge branch 'matplotlib:main' into bugfix-for-issue-29780

0b663fe

Taking whitespaces

b8c9a72

github-actions Bot added the status: needs rebase label Apr 24, 2025

Merge branch 'main' into bugfix-for-issue-29780

b9a0864

github-actions Bot removed the status: needs rebase label Apr 28, 2025

timhoffm reviewed Apr 28, 2025

View reviewed changes

Comment thread lib/matplotlib/tests/test_axes.py Outdated

Update lib/matplotlib/tests/test_axes.py

9e0df6c

timhoffm reviewed Apr 28, 2025

View reviewed changes

ksunden modified the milestones: v3.10.2, v3.10.3 May 2, 2025

Update lib/matplotlib/tests/test_axes.py

0984d4c

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

Alteration of the tests

63abf89

timhoffm approved these changes May 14, 2025

View reviewed changes

QuLogic approved these changes May 15, 2025

View reviewed changes

QuLogic merged commit 20bdd72 into matplotlib:main May 15, 2025

lumberbot-app Bot added the Still Needs Manual Backport label May 15, 2025

useidemaisachola deleted the bugfix-for-issue-29780 branch May 15, 2025 15:46

QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request May 15, 2025

Backport PR matplotlib#29895 : The 'lines.markeredgecolor' now doesn't…

6ea55ca

… interfere on the color of errorbar caps

QuLogic changed the title The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps May 15, 2025

QuLogic removed the Still Needs Manual Backport label May 15, 2025

dstansby added a commit that referenced this pull request May 17, 2025

Merge pull request #30057 from QuLogic/auto-backport-of-pr-29895-on-v…

bb7655b

…3.10.x Backport PR #29895 on branch v3.10.x (The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps)"

ksunden mentioned this pull request Aug 7, 2025

merge up v3.10.5 #30401

Merged

5 tasks

ksunden pushed a commit to ksunden/matplotlib that referenced this pull request Aug 21, 2025

Backport PR matplotlib#29895 : The 'lines.markeredgecolor' now doesn't…

d127eb8

… interfere on the color of errorbar caps

The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps by useidemaisachola · Pull Request #29895 · matplotlib/matplotlib · GitHub

Uh oh!

Uh oh!

The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps - #29895

The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps#29895QuLogic merged 9 commits intomatplotlib:mainmatplotlib/matplotlib:mainfrom useidemaisachola:bugfix-for-issue-29780useidemaisachola/matplotlib:bugfix-for-issue-29780Copy head branch name to clipboard

Conversation

useidemaisachola commented Apr 10, 2025

PR summary

PR checklist

Uh oh!

tacaswell commented Apr 11, 2025

Uh oh!

tacaswell commented Apr 11, 2025

Uh oh!

useidemaisachola commented Apr 12, 2025

Uh oh!

QuLogic commented Apr 12, 2025

Uh oh!

useidemaisachola commented Apr 12, 2025

Uh oh!

useidemaisachola commented Apr 19, 2025

Uh oh!

rcomer commented Apr 20, 2025

Uh oh!

useidemaisachola commented Apr 25, 2025

Uh oh!

rcomer commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

useidemaisachola commented Apr 28, 2025

Uh oh!

Uh oh!

timhoffm commented Apr 28, 2025

Uh oh!

Uh oh!

timhoffm Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

useidemaisachola commented Apr 28, 2025

Uh oh!

useidemaisachola commented May 7, 2025

Uh oh!

QuLogic commented May 7, 2025

Uh oh!

useidemaisachola commented May 9, 2025

Uh oh!

useidemaisachola commented May 14, 2025

Uh oh!

useidemaisachola commented May 14, 2025

Uh oh!

timhoffm commented May 14, 2025

Uh oh!

useidemaisachola commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuLogic commented May 15, 2025

Uh oh!

lumberbot-app Bot commented May 15, 2025

Uh oh!

useidemaisachola commented May 15, 2025

Uh oh!

rcomer commented May 15, 2025

Uh oh!

useidemaisachola commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

The 'lines.markeredgecolor' now doesn't interfere on the color of errorbar caps#29895
QuLogic merged 9 commits into
matplotlib:mainfrom
useidemaisachola:bugfix-for-issue-29780

rcomer commented Apr 25, 2025 •
edited
Loading

useidemaisachola commented May 14, 2025 •
edited
Loading