| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Rebased 🤞 |
Sorry, something went wrong.
|
I have no idea why these tests are failing. The striped line test failure looks like The legend seems genuinely slightly taller than in the reference. |
Sorry, something went wrong.
|
Ah, this would need #29907, which wasn't backported. |
Sorry, something went wrong.
|
What's the preferred solution here then - backport #29907 or just update the test image here? |
Sorry, something went wrong.
|
This is wrapped up in the freetype side of things, so not going to hold 3.10.2 on it (since we're not waiting on that for 3.10.2). That said, may be worth getting all of these backported if we are going this route, which I think is the consensus (and my personal opinion). |
Sorry, something went wrong.
|
I decided to start a backport of #29907. If people started using the text_placeholders fixture (probably unlikely, I'm sure), then we'd want the results to be right from the get go. |
Sorry, something went wrong.
|
How much will we still backport to 3.10.x? If we don't need backports that add new test images or modify the existing ones, we could leave 3.10.x on the images with text. It should reach end-of-life in the near future. |
Sorry, something went wrong.
|
I'm inclined to abandon this as it stands (sorry for wasting the rebase effort @rcomer ). If we do end up backporting the freetype work we will deal with this then. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Backport PR #29908: TST: Use text placeholders for empty legends