| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks a lot - looks good to me.
Sorry, something went wrong.
|
Thanks and congratulations on your first merged PR in Matplotlib. Looks that there may be two soon. Hoping to see you around! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR summary
This PR adds a new test to verify that changing the colormap of a 3D scatter plot (Axes3D.scatter) after drawing the figure properly updates the face colors.
Why is this change necessary?
There was previously no test ensuring that colormap updates on 3D scatter plots are reflected after a figure draw. This test ensures consistency with 2D behavior and guards against regressions.
What problem does it solve?
Confirms that calling set_cmap() after drawing does in fact update the plotted colors in 3D, which has historically been a bug but seems to be fixed.
What is the reasoning for this implementation?
The test draws a 3D scatter plot with an initial colormap ('jet'), forces a draw, changes the colormap to 'viridis', and compares it against a reference plot created directly with 'viridis'.
This ensures the update mechanism behaves correctly post-render.
Minimal example
Closes #18931
PR checklist