FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Close star polygons by jkseppan · Pull Request #30069 · matplotlib/matplotlib · GitHub

Repository navigation

Close star polygons - #30069

Merged
rcomer merged 1 commit into
matplotlib:mainfrom
jkseppan:close-star
May 18, 2025
Merged

rcomer merged 1 commit into
matplotlib:mainfrom
jkseppan:close-star

Conversation

jkseppan commented May 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

When '*' hatching was used and you zoomed in (especially in vector formats), the top of the star was not joined quite right. Using closepoly as the last operation fixes this.

Before:

After:

See also #29392 which fills the stars.

oscargus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As I happened to note that the clip_path-test was updated: is this enough and the newly added test can be removed? Of course, it can be good to have an explicit test for this (in case someone modifies the clip_path-test and removes the hatch.

Copy link
Copy Markdown
Member Author

As I happened to note that the clip_path-test was updated: is this enough and the newly added test can be removed? Of course, it can be good to have an explicit test for this (in case someone modifies the clip_path-test and removes the hatch.

Perhaps the clip_path test is enough. I was planning to make a zoomed-in test to really show the change, but of course the hatch markers are in display coordinates so you have to zoom in the file viewer and not when producing the image.

When '*' hatching was used and you zoomed in (especially in vector
formats), the top of the star was not joined quite right. Using
closepoly as the last operation fixes this.
rcomer merged commit f4346b5 into matplotlib:main May 18, 2025
rcomer added this to the v3.11.0 milestone May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL