Repository navigation
Prepare to turn matplotlib.style into a plain module. - #30163
Merged
jkseppan merged 1 commit intoJun 24, 2025
Merged
jkseppan merged 1 commit into
jkseppan merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
ms
branch
3 times, most recently
from
6dbfc13 to
9d16b89
Compare
June 11, 2025 18:49
tacaswell
approved these changes
Jun 12, 2025
Copy link
Copy Markdown
Contributor
Author
|
mypy seems unhappy lib/matplotlib/style/__init__.py:241: error: Need type annotation for "library" (hint: "library: dict[<type>, <type>] = ...") [var-annotated] lib/matplotlib/style/__init__.py:242: error: Need type annotation for "available" (hint: "available: list[<type>] = ...") [var-annotated] even though these are clearly listed in __init__.pyi, do you know why/how to fix this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I suspect it is the issue is that it is missing from the meson.build. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ah, thanks for pointing it out. Dropping style/meson.build is probably another good reason for the change :) |
Sorry, something went wrong.
Having matplotlib.style be a package with the entire implementation in matplotlib.style.core is a bit overkill, and also makes it slightly awkward that USER_LIBRARY_PATHS is effectively a public API (clearly intended as so, per the comment, even though we may do it differently nowadays...) but only available in matplotlib.style.core, whereas everything else is re-exported by matplotlib.style. Prepare to flatten the implementation by deprecating matplotlib.style.core and reexporting USER_LIBRARY_PATHS in matplotlib.style. Once the deprecation elapses, we'll be able to move the implementation into a plain matplotlib/style.py module.
jkseppan
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having matplotlib.style be a package with the entire implementation in matplotlib.style.core is a bit overkill, and also makes it slightly awkward that USER_LIBRARY_PATHS is effectively a public API (clearly intended as so, per the comment, even though we may do it differently nowadays...) but only available in matplotlib.style.core, whereas everything else is re-exported by matplotlib.style.
Prepare to flatten the implementation by deprecating matplotlib.style.core and reexporting USER_LIBRARY_PATHS in matplotlib.style. Once the deprecation elapses, we'll be able to move the implementation into a plain matplotlib/style.py module.
PR summary
PR checklist