| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
As mentioned in #27882, the real test here is that failed images still get uploaded. Have you checked that in your other PR? |
Sorry, something went wrong.
|
Yup. I set the PR to have a single failing image comparison. The uploaded artifact archive was only ~400 kB instead of ~50 MB and had only the three images corresponding to the single failed test (plus the test_backend_ps and test_backend_pgf images that aren't as easily cleaned). |
Sorry, something went wrong.
|
The failed 3.13 test looked like something went wrong with compiling + freethreading which I'm very sure is unrelated to this change, but re-started the tests. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR summary
This PR fixes a bug with #27882, which intended to delete all images that have passed tests before uploading the artifact. However, due to the specification of -type f in the find call, it inadvertently skips over images where the expected image is a symbolic link rather than an actual file. All of the baseline images in the repository are symbolically linked in the results folder (#10222), so #27882 actually deleted only those images where the expected image was dynamically generated.
This PR also extends the cleanup to GIF files (of which there is exactly one test).
I've tested this modification in a different PR, so I know that it successfully reduces the size of the uploaded artifact by ~50 MB. A few images (total of 370 kB) manage to still escape the cleanup, but I think that's small enough to put up with:
PR checklist