Repository navigation
Use collections.deque to store animation cache data. - #30206
Merged
jkseppan merged 1 commit intoJun 24, 2025
Merged
jkseppan merged 1 commit into
jkseppan merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
QuLogic
requested changes
Jun 23, 2025
QuLogic
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
There is a self._save_seq = [] in _init_draw that was missed.
Sorry, something went wrong.
Comment thread
lib/matplotlib/animation.py
Outdated
| # Need to reset the saved seq, since right now it will contain data | ||
| # for a single frame from init, which is not what we want. | ||
| self._save_seq = [] | ||
| self._save_seq = collections.deque([], self._save_count) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can't just clear it?
Suggested change
| self._save_seq = collections.deque([], self._save_count) | |
| self._save_seq.clear() |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
sure, even better.
Sorry, something went wrong.
deques are exactly suited for the task at hand, and should be (here, marginally) more efficient than repeatedly slicing off the start of the list. Also drop unneeded reference to old_frame_seq (the iterator already keeps that data alive).
Copy link
Copy Markdown
Contributor
Author
|
thanks, fixed |
Sorry, something went wrong.
QuLogic
approved these changes
Jun 23, 2025
jkseppan
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deques are exactly suited for the task at hand, and should be (here, marginally) more efficient than repeatedly slicing off the start of the list.
Also drop unneeded reference to old_frame_seq (the iterator already keeps that data alive).
PR summary
PR checklist