| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I don't think we can merge this until we require Pillow 11.2.1 (the first version to support avif). |
Sorry, something went wrong.
|
Well, the formats are not changing that often, so that piecemeal can be good enough. The problem with the version exists, but is bearable. People will get an error message if their pillow is too old. Maybe check if that message is good enough or whether we should provide a better message.
From a quick look, I did not see anything in the documentation, but AI suggests # Get the list of supported formats for opening images
supported_open_formats = Image.OPEN.keys()
# Get the list of supported formats for saving images
supported_save_formats = Image.SAVE.keys()would need investigation what exactly is in there and whether we can use it. Edit: Actually, this can be done via PIL.features |
Sorry, something went wrong.
|
Please add a test test_pil_kwargs_avif() similar to the existing test_pil_kwargs_* tests here matplotlib/lib/matplotlib/tests/test_agg.py Line 233 in 011d12f Note: Use the feature query like here to selectively skip the test matplotlib/lib/matplotlib/tests/test_agg.py Line 252 in 011d12f |
Sorry, something went wrong.
|
Ok so I added the test for transparency too, and the kwargs test is basically a copy of the webp test that checks compression quality and kwargs, tell me if there is anything else that should be tested in there. |
Sorry, something went wrong.
|
Test for ubuntu ARM failed, is this a problem? it seems that it just disconnected, I doubt I made something that makes it fail |
Sorry, something went wrong.
There was a problem hiding this comment.
Minor suggestions
Sorry, something went wrong.
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
…plotlib into bugfix-for-issue-28809
|
Thank you so much for your feedback Tim :) |
Sorry, something went wrong.
|
closed by accident lol |
Sorry, something went wrong.
There was a problem hiding this comment.
Minor issues.
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
Thanks @AndrGutierrez! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Sorry, something went wrong.
|
It was a very nice experience, thank you for all the feedback, I will try to contribute more so ping me if there is something I can help with |
Sorry, something went wrong.
|
Feel free to join our New Contributors Meeting or #incubator channel: https://matplotlib.org/devdocs/devel/contribute.html#new-contributors |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR summary
closes #28809
This fixes the error
ValueError: Format 'avif' is not supported (supported formats: eps, jpeg, jpg, pdf, pgf, png, ps, raw, rgba, svg, svgz, tif, tiff, webp) mentioned when saving a .avif figure by doing fig.savefig('test.avif') .
I am not sure if I should add new tests for this, however I got the same results I got when merging the main branch so I would like feedback on that
PR checklist