Fix a race condition in TexManager.make_dvi. - #30426
Merged
timhoffm merged 1 commit intoAug 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tacaswell
reviewed
Aug 14, 2025
Comment thread
lib/matplotlib/texmanager.py
Outdated
tacaswell
approved these changes
Aug 14, 2025
tacaswell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think there is an unused local, but otherwise good to merge.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
It's still used by the TemporaryDirectory call. |
Sorry, something went wrong.
timhoffm
reviewed
Aug 14, 2025
Previously, a race condition could occur if, while a process had called make_tex (generating the tex file in the global cache) and was going to call the latex subprocess (to generate the dvi file), another process also called make_tex for the same tex string and started rewriting the tex source. In that case, the latex subprocess could see a partially written (invalid) tex source. Fix that by generating the tex source in a process-private temporary directory, where the latex process is already going to run anyways. (This is cheap compared to the latex subprocess invocation.) Apply a similar strategy for make_png as well.
Copy link
Copy Markdown
Contributor
Author
|
I chose to also fix make_png here as well. |
Sorry, something went wrong.
timhoffm
approved these changes
Aug 14, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 14, 2025
anntzer
added a commit
to anntzer/matplotlib
that referenced
this pull request
Aug 16, 2025
…_dvi & make_png. Includes an extra fix from PR matplotlib#30431: Don't drop dpi in png filename generation.
QuLogic
added a commit
that referenced
this pull request
Aug 18, 2025
Backport PR #30426: Fix a race condition in TexManager.make_dvi & make_png.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a race condition could occur if, while a process had called make_tex (generating the tex file in the global cache) and was going to call the latex subprocess (to generate the dvi file), another process also called make_tex for the same tex string and started rewriting the tex source. In that case, the latex subprocess could see a partially written (invalid) tex source.
Fix that by generating the tex source in a process-private temporary directory, where the latex process is already going to run anyways. (This is cheap compared to the latex subprocess invocation.)
See #30420 (comment) (point (2)).
Edit: did the same to make_png.
PR summary
PR checklist