FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PoC: GUI-native crosshair cursor by timhoffm · Pull Request #30516 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

PoC: GUI-native crosshair cursor #30516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timhoffm wants to merge 2 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 3 Commits 2 Checks 37 Files changed
Draft

PoC: GUI-native crosshair cursor #30516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe0fbd0
PoC: GUI-native crosshair cursor [skip ci]
timhoffm Sep 4, 2025
804b503
Limit crosshair to axes region
timhoffm Sep 5, 2025
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
26 changes: 25 additions & 1 deletion lib/matplotlib/backends/backend_qt.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from collections import namedtuple
import functools
import os
import sys
Expand Down Expand Up @@ -213,6 +214,9 @@ def _timer_stop(self):
self._timer.stop()


Crosshair = namedtuple('Crosshair', 'x, y, x0, x1, y0, y1')


class FigureCanvasQT(FigureCanvasBase, QtWidgets.QWidget):
required_interactive_framework = "qt"
_timer_cls = TimerQT
Expand All @@ -231,6 +235,7 @@ class FigureCanvasQT(FigureCanvasBase, QtWidgets.QWidget):
def __init__(self, figure=None):
_create_qApp()
super().__init__(figure=figure)
self._crosshair = None

self._draw_pending = False
self._is_drawing = False
Expand Down Expand Up @@ -305,6 +310,21 @@ def mouseEventCoords(self, pos=None):
y = self.figure.bbox.height / self.device_pixel_ratio - pos.y()
return x * self.device_pixel_ratio, y * self.device_pixel_ratio

def _update_crosshair(self, x, y):
previous_crosshair = self._crosshair
ax = self.inaxes((x, y))
if ax is None:
self._crosshair = None
else:
bbox = ax.get_position() # in figure coords
x0 = int(bbox.x0 * self.width())
x1 = int(bbox.x1 * self.width())
y0 = int((1 - bbox.y0) * self.height())
y1 = int((1 - bbox.y1) * self.height())
self._crosshair = Crosshair(x, y, x0, x1, y0, y1)
needs_repaint = previous_crosshair is not None or self._crosshair is not None
return needs_repaint

def enterEvent(self, event):
# Force querying of the modifiers, as the cached modifier state can
# have been invalidated while the window was out of focus.
Expand Down Expand Up @@ -344,8 +364,12 @@ def mouseDoubleClickEvent(self, event):
def mouseMoveEvent(self, event):
if self.figure is None:
return
mouse_xy = self.mouseEventCoords(event)
needs_repaint = self._update_crosshair(*mouse_xy)
if needs_repaint:
self.repaint()
MouseEvent("motion_notify_event", self,
*self.mouseEventCoords(event),
*mouse_xy,
buttons=self._mpl_buttons(event.buttons()),
modifiers=self._mpl_modifiers(),
guiEvent=event)._process()
Expand Down
11 changes: 11 additions & 0 deletions lib/matplotlib/backends/backend_qtagg.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ def paintEvent(self, event):
ctypes.c_long.from_address(id(buf)).value = 1

self._draw_rect_callback(painter)

if self._crosshair is not None:
x = self._crosshair.x
y = rect.height() - int(self._crosshair.y)
x0 = rect.left() + self._crosshair.x0
x1 = rect.left() + self._crosshair.x1
y0 = rect.top() + self._crosshair.y0
y1 = rect.top() + self._crosshair.y1
painter.setPen(QtGui.QPen(QtCore.Qt.GlobalColor.red))
painter.drawLine(x0, y, x1, y)
painter.drawLine(x, y0, x, y1)
finally:
painter.end()

Expand Down
Loading
Back | FazBrowse Home | New Git URL