FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BUG : fix for text path rendering issues by tacaswell · Pull Request #3054 · matplotlib/matplotlib · GitHub

Repository navigation

BUG : fix for text path rendering issues - #3054

Closed
tacaswell wants to merge 1 commit into
matplotlib:masterfrom
tacaswell:text_path_fix
Closed

tacaswell wants to merge 1 commit into
matplotlib:masterfrom
tacaswell:text_path_fix

Conversation

Copy link
Copy Markdown
Member

Suggested by @leejjoon.

Fixes #2889

tacaswell added this to the v1.4.0 milestone May 9, 2014

Copy link
Copy Markdown
Member Author

This still needs a test + docs.

pelson commented May 14, 2014

Copy link
Copy Markdown
Member

This still needs a test + docs.

I'm not sure about the docs, but the test should be relatively straight forward. It also appears to be impacting other test results, suggesting that this functionality is fixing already tested behaviour.

I'm 👍 on merging the method once the (potentially simple, picture-less) test exists.

Copy link
Copy Markdown
Member Author

It looks like it is breaking existing behavior....

I don't really understand what is going on here well enough to write tests.

pelson commented May 21, 2014

Copy link
Copy Markdown
Member

`FAIL: matplotlib.tests.test_patheffects.test_patheffect3``

This is good. It fixes an image which I added a few months ago (in which I struggled to get the font to be the expected size!!!).

FAIL: matplotlib.tests.test_patheffects.test_collection

This is good too - it fills the space in the boxes that I (again) struggled to understand why it didn't in the first place (test also added by me a few months ago).

So all in all - this is doing the right thing 😄

pelson mentioned this pull request May 21, 2014

pelson commented May 21, 2014

Copy link
Copy Markdown
Member

Closed in favour of #3081.

pelson closed this May 21, 2014
tacaswell deleted the text_path_fix branch May 21, 2014 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: path effects in text() change text properties

2 participants


Back | FazBrowse Home | New Git URL