Repository navigation
MNT: Make useblit a property in Widget classes - #30605
Closed
tacaswell wants to merge 1 commit into
Closed
tacaswell wants to merge 1 commit into
tacaswell wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The goal is to skip trying to do anything with blitting when after the figure is closed a blitting-capable Canvas instance is swapped out for one that does not support blitting. closes matplotlib#30575 but in only a partial solution to the bigger issues with blitting and changing the canvas.
2 tasks done
Copy link
Copy Markdown
Member
|
I think this PR is a bit dangerous by itself. It makes sure that the the useblit status calculated dynamically and thus correctly. However we sometimes have state (background images) that are calculated based on the useblit status and canvas at some point in time. If that is not correctly updated as well, we'll still get inconsistent behavior. I've taken a more comprehensive approach in #30591, see in particular #30591 (comment) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Closing this in favor of #30591. Sorry for the duplicate effort. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to skip trying to do anything with blitting when after the figure is closed a blitting-capable Canvas instance is swapped out for one that does not support blitting.
closes #30575 but in only a partial solution to the bigger issues with blitting and changing the canvas.
PR summary
Attempts to make useblit dynamic (and standardiizes it across all of the widget classes)
Not tested with MNE's case and have not sorted out a MWE to add a test.
PR checklist