FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use std::visit to exhaust std::variant possibilities. by anntzer · Pull Request #30773 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Use std::visit to exhaust std::variant possibilities. - #30773

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
anntzer:visit
Jul 28, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Use std::visit to exhaust std::variant possibilities.#30773
QuLogic merged 1 commit into
matplotlib:mainfrom
anntzer:visit

Conversation

anntzer commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

This makes it unnecessary to silence impossible "unhandled" cases. See #30607 (comment).

PR summary

PR checklist

QuLogic changed the base branch from main to text-overhaul November 21, 2025 15:25
QuLogic closed this Nov 21, 2025
QuLogic reopened this Nov 21, 2025
QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Jan 17, 2026
QuLogic approved these changes Jan 17, 2026
View reviewed changes

QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IIRC, the reason for the std::get_if with an else instead of a plain std::get was that some old macOS deployment target didn't have the implementation. Since cibuildwheel appears okay with this build, I think this should be okay for us and looks clearer, for the most part.

QuLogic commented Jul 17, 2026

Copy link
Copy Markdown
Member

Can you rebase again? All the deprecated code paths are gone now.

QuLogic commented Jul 23, 2026

Copy link
Copy Markdown
Member

I rebased this to fix the conflicts and added a second change of languages in ft2font_wrapper.cpp.

anntzer commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Looks like you forgot to push your rebase?

Use std::visit to exhaust std::variant possibilities
92416fb 
This makes it unnecessary to silence impossible "unhandled" cases.

QuLogic commented Jul 27, 2026

Copy link
Copy Markdown
Member

Well, I did, but I forgot that #30291 was merged and didn't rebase on top of that.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
story645 story645 approved these changes

Assignees

No one assigned

Labels

Maintenance topic: text/fonts

Projects

None yet

Milestone

v3.12.0

Development

Successfully merging this pull request may close these issues.

[MNT]: Remove macOS 10.12 compatibility from ft2font_wrapper

3 participants

Back | FazBrowse Home | New Git URL