Repository navigation
Revamp draw_path_collection() API. - #30811
Open
r3kste wants to merge 1 commit into
Open
r3kste wants to merge 1 commit into
r3kste wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Pranav <kingprawn5000@gmail.com> Co-authored-by: AdwaithBatchu <adwaithbatchu@gmail.com> Co-authored-by: Sreekanth-M8 <kmsreekanthsai@gmail.com> Co-authored-by: Sujal Kumar <sujaljayantkumar06@gmail.com>
r3kste
force-pushed
the
draw_path_collection_refactor
branch
from
195e00e to
a1ba476
Compare
December 4, 2025 21:29
Copy link
Copy Markdown
Member
|
Thanks for the PR. I‘d like to hold this off until #30777 is in. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
closes #30547
This PR enhances the API of draw_path_collection() for long term maintainability.
Summary of Changes
Introduces the new VectorizedGraphicsContextBase class, which is similar to GraphicsContextBase, but each attribute is vectorized. This serves as the dataclass through which all parameters are passed to draw_path_collection().
Updated signature of draw_path_collection() by making the parameters optional in order to support both the following:
Updated signature of _iter_collection() to take vgc instead of gc and added logic to cycle through all attributes.
Changed draw() in Collection to use the new draw_path_collection() API along with temporary fallback for third-party backends that use the old signature.
Why is this change required?
It would become much simpler to add / vectorize new attributes in collections, without completely breaking third party backends. For example, it would greatly simplify #27937, that aims to vectorize the hatch attribute.
To-do
PR checklist