| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Hi, Since you mentioned Starplot in matplotlib/matplotlib#30960, figured you might be interested in identifying the project as an mpl downstream library on PyPI via the trove classifier. Also please consider your very cool library to https://matplotlib.org/thirdpartypackages/
|
Thanks for the PR! What happens if someone passes in a string fontweight (for example they're saving to multiple filetypes)? |
Sorry, something went wrong.
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
Thanks for the bug fix! |
Sorry, something went wrong.
…960-on-v3.10.x Backport PR #30960 on branch v3.10.x (SVG backend - handle font weight as integer)
…t-of-pr-30960-on-v3.10.x Backport PR matplotlib#30960 on branch v3.10.x (SVG backend - handle font weight as integer)
PR: matplotlib#30964 Issue: matplotlib#30960 Base commit: 2f0ea8b Changed lines: 11
| Back | FazBrowse Home | New Git URL |
PR summary
This fixes a small bug with handling integer font weights when rendering text in SVGs as elements vs paths (i.e. plt.rcParams['svg.fonttype'] = 'none').
To reproduce:
Raises:
The problem is that the font weight_dict is keyed on the string values, but get_weight returns an integer.
PR checklist
I couldn't find an open issue for this, but let me know if one exists already. This is also my first PR to matplotlib, so let me know if there's anything I missed in your contribution process. Appreciate any feedback! And, thanks so much for maintaining this library! It's the backbone of Starplot, a sky mapping library I maintain.