| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Adding _update_collection_limits could be a reasonable intermediate step to make handling more consistent. But overall, we likely want to move a way from _update_* methods, see #15595 (comment). Edit: It may be much more complicated than this. Since we have the option add_collection(..., autolim=False) we must not always update. If a user/function has decided not to update the limits, we must not push updates through the backdoor of relim(). This means the bug cannot be fixed properly without addressing the general set_in_autoscale concept (#15595) - or hacking in a speical solution for collections, which is most likely not the way to go. |
Sorry, something went wrong.
|
@Archiljain thanks for the contribution so far. As the topic is more involved, we cannot do a standalone solution without tackling a mechanism that makes inclusion of Artists in autoscaling optional. Following up on my previous note regarding entanglement of Collection limits considered in relim() and optional inclusion in autoscaling, I think the way forward is this:
|
Sorry, something went wrong.
|
Thanks for the clarification. I'm happy to work on PR1 (implementing the private set_in_autoscale mechanism) as a first step if that helps move this forward. Please let me know if that’s the preferred direction. |
Sorry, something went wrong.
|
@Archiljain you are welcome to work on this. Please read the full discussion in #15595 and use for context, in particular #15595 (comment). Since this is internal for now, naming is not too critical. I would stick to the in_autoscale terminology for now. But we may come up with a better name. |
Sorry, something went wrong.
|
I propose introducing a private Artist-level _in_autoscale flag (mirroring _in_layout), checked centrally in Axes.relim() to gate whether an artist contributes to data limits. No behavior change yet. |
Sorry, something went wrong.
|
Thanks for the guidance. I see that this needs a more foundational change. |
Sorry, something went wrong.
|
This should be re-done in a new PR; #31166 contained these commits so GitHub marked it as merged, but it also reverted all these changes, so they haven't actually landed in main. |
Sorry, something went wrong.
|
I'm planning to apply for GSoC this year and would love to continue contributing to autoscaling improvements. Are there related issues where help would be valuable? |
Sorry, something went wrong.
PR: matplotlib#31128 Issue: matplotlib#30859 Base commit: 08fe8bc Changed lines: 33
| Back | FazBrowse Home | New Git URL |
Fixes issue where ax.relim() does not update limits after scatter
offsets are changed via set_offsets().
Adds handling for Collection artists in Axes.relim() by
updating data limits from collection offsets.
Includes a regression test to verify that axis limits update
correctly after scatter data changes.
Closes #30859