FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add private Artist-level autoscale participation flag by Archiljain · Pull Request #31166 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Add private Artist-level autoscale participation flag #31166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksunden merged 10 commits into from
Mar 6, 2026
Conversation 24 Commits 10 Checks 38 Files changed
Merged

Add private Artist-level autoscale participation flag #31166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
529d37c
Fix relim() to update limits for scatter PathCollection and add regre…
Archiljain Feb 10, 2026
defd13e
Refactor: use _update_collection_limits for scatter handling in relim
Archiljain Feb 10, 2026
fbb623e
Fix ruff E302: add missing blank line before test
Archiljain Feb 10, 2026
5bf5273
Add private Artist-level autoscale participation flag
Archiljain Feb 16, 2026
7247fa5
Make autoscale participation fully artist-driven and Remove scatter r…
Archiljain Feb 18, 2026
b527465
fixing CI fails
Archiljain Feb 18, 2026
0ad2c0a
removed the set_in_autoscale from add_artist
Archiljain Feb 26, 2026
6c702b6
Update lib/matplotlib/artist.py
Archiljain Feb 26, 2026
bcf2fc2
Update lib/matplotlib/artist.py
Archiljain Feb 26, 2026
31f59f4
Removed update limit function and autolim
Archiljain Feb 26, 2026
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
20 changes: 20 additions & 0 deletions lib/matplotlib/artist.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def __init__(self):
self._path_effects = mpl.rcParams['path.effects']
self._sticky_edges = _XYPair([], [])
self._in_layout = True
self._in_autoscale = False

def __getstate__(self):
d = self.__dict__.copy()
Expand Down Expand Up @@ -903,6 +904,14 @@ def get_in_layout(self):
"""
return self._in_layout

def _get_in_autoscale(self):
"""
Return whether the artist is included in autoscaling calculations.

E.g. `.axes.Axes.autoscale_view()`.
"""
return self._in_autoscale
Comment thread
Archiljain marked this conversation as resolved.

def _fully_clipped_to_axes(self):
"""
Return a boolean flag, ``True`` if the artist is clipped to the Axes
Expand Down Expand Up @@ -1132,6 +1141,17 @@ def set_in_layout(self, in_layout):
"""
self._in_layout = in_layout

def _set_in_autoscale(self, b):
"""
Set if artist is to be included in autoscaling calculations,
E.g. `.axes.Axes.autoscale_view()`.

Parameters
----------
b : bool
"""
self._in_autoscale = b

timhoffm Feb 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To be checked: Do we need to set the self._stale flag?

Archiljain Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don’t think _set_in_autoscale should mark the artist as stale.

The flag only affects whether the artist participates in future autoscaling; it doesn’t change the artist’s visual state or require a redraw on its own. In practice it’s set during add_*, before any drawing occurs, so marking it stale would be unnecessary.

timhoffm Feb 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok, so the argument is that changing in_autoscale will not result in automatic recalculation of the limits. Accepted.

Can you please add a sentence on this to the docstring.

def get_label(self):
"""Return the label used for this artist in the legend."""
return self._label
Expand Down
5 changes: 5 additions & 0 deletions lib/matplotlib/axes/_base.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2409,6 +2409,7 @@ def add_image(self, image):
self._children.append(image)
image._remove_method = self._children.remove
self.stale = True
image._set_in_autoscale(True)
return image

def _update_image_limits(self, image):
Expand All @@ -2430,6 +2431,7 @@ def add_line(self, line):
self._children.append(line)
line._remove_method = self._children.remove
self.stale = True
line._set_in_autoscale(True)
return line

def _add_text(self, txt):
Expand Down Expand Up @@ -2502,6 +2504,7 @@ def add_patch(self, p):
self._update_patch_limits(p)
self._children.append(p)
p._remove_method = self._children.remove
p._set_in_autoscale(True)
return p

def _update_patch_limits(self, patch):
Expand Down Expand Up @@ -2599,6 +2602,8 @@ def relim(self, visible_only=False):

for artist in self._children:
if not visible_only or artist.get_visible():
if not artist._get_in_autoscale():
continue
if isinstance(artist, mlines.Line2D):
self._update_line_limits(artist)
elif isinstance(artist, mpatches.Patch):
Expand Down
Loading
Back | FazBrowse Home | New Git URL