FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Copy-edit the transform tutorial. by anntzer · Pull Request #31167 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Copy-edit the transform tutorial. - #31167

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
anntzer:tt
Feb 17, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Copy-edit the transform tutorial.#31167
timhoffm merged 1 commit into
matplotlib:mainfrom
anntzer:tt

Conversation

anntzer commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

PR summary

Closes #24499 (see in particular #24499 (comment)).

PR checklist

github-actions Bot added Documentation: user guide files in galleries/users_explain or doc/users and removed topic: transforms and scales labels Feb 16, 2026
story645 reviewed Feb 16, 2026
View reviewed changes
Comment thread galleries/users_explain/artists/transforms_tutorial.py Outdated
Comment on lines +566 to +569
# For non-separable axes, such as PolarAxes, there are some more pieces to
# consider, in particular the projection transformation. The ``transData`` of
# `matplotlib.projections.polar.PolarAxes` is similar to that of
# the typical separable Axes, but includes some additional pieces::

story645 Feb 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
# For non-separable axes, such as PolarAxes, there are some more pieces to
# consider, in particular the projection transformation. The ``transData`` of
# `matplotlib.projections.polar.PolarAxes` is similar to that of
# the typical separable Axes, but includes some additional pieces::
# For non-separable axes, there are some more pieces to
# consider, in particular the projection transformation. For example, the ``transData`` of
# `matplotlib.projections.polar.PolarAxes` includes ::

trying to remove some of the overlap

anntzer Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, included that with some additional editing.

story645 Feb 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

uh I'm confused b/c all the overlaps still seem to be in the new version?

anntzer Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Edited again; how does the new version look to you?

story645 Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Got merged while I was sleeping but thanks for making the changes, much better!

story645 previously approved these changes Feb 16, 2026
View reviewed changes
story645 dismissed their stale review February 16, 2026 22:38

accident

timhoffm merged commit 7eaff94 into matplotlib:main Feb 17, 2026
20 checks passed
anntzer deleted the tt branch February 17, 2026 16:11
QuLogic added this to the v3.11.0 milestone Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

story645 story645 left review comments
timhoffm timhoffm approved these changes
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

Documentation: user guide files in galleries/users_explain or doc/users Documentation

Projects

None yet

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

[Doc]: Transformation tutorial uses outdated description for polar transform

5 participants

Back | FazBrowse Home | New Git URL