FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: Fix rendering of quiver documentation by amishamehta99 · Pull Request #31252 · matplotlib/matplotlib · GitHub

Repository navigation

DOC: Fix rendering of quiver documentation - #31252

Merged
story645 merged 22 commits into
matplotlib:mainfrom
amishamehta99:fix-quiver-doc-render
Mar 13, 2026
Merged

story645 merged 22 commits into
matplotlib:mainfrom
amishamehta99:fix-quiver-doc-render

Conversation

Copy link
Copy Markdown
Contributor

Fixes #31235

Removed unintended indentation in the quiver documentation that caused the
formula lines to render as a code block in the generated documentation.

rcomer commented Mar 7, 2026

Copy link
Copy Markdown
Member

Hi @amishamehta99 thank you for your contribution. I’m going to put this in draft for now while you fix the linting and doc-build failures. The easiest way to check the linting locally is to install the pre-commit hooks.
https://matplotlib.org/devdocs/devel/development_setup.html#pre-commit-hooks

You can also build the docs locally to ensure that the build succeeds and renders how you intend.
https://matplotlib.org/devdocs/devel/document.html#build-docs

Please mark this as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator chat room for new contributors.

rcomer marked this pull request as draft March 7, 2026 14:01
amishamehta99 marked this pull request as ready for review March 8, 2026 08:51

Copy link
Copy Markdown
Contributor Author

Hi @amishamehta99 thank you for your contribution. I’m going to put this in draft for now while you fix the linting and doc-build failures. The easiest way to check the linting locally is to install the pre-commit hooks. https://matplotlib.org/devdocs/devel/development_setup.html#pre-commit-hooks

You can also build the docs locally to ensure that the build succeeds and renders how you intend. https://matplotlib.org/devdocs/devel/document.html#build-docs

Please mark this as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator chat room for new contributors.

Hi @rcomer, thanks for the guidance. I’ve installed the pre-commit hooks, applied the fixes, and marked the PR ready for review. The CI checks are currently running again. Please let me know if any further changes are needed.

rcomer commented Mar 8, 2026

Copy link
Copy Markdown
Member

@amishamehta99 you haven’t pushed anything. Please check that the documentation renders as expected before asking for review again. I note that you were asked to do that four days ago #31235 (comment)

rcomer marked this pull request as draft March 8, 2026 10:26

amishamehta99 commented Mar 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@amishamehta99 you haven’t pushed anything. Please check that the documentation renders as expected before asking for review again. I note that you were asked to do that four days ago #31235 (comment)

Hi!Thanks for reminding me. Also, due to some glitch the changes werent pushed, apologies. The CI failure appears to be a 'test_webagg' timeout. Since this PR only updates a docstring, it seems unrelated. I have made the required changes. Could someone with permissions please rerun the CI jobs?Suggest changes, if any. Thank you!

rcomer commented Mar 8, 2026

Copy link
Copy Markdown
Member

The webagg timeout is indeed flaky and can be ignored.

The rendered docs for quiver still look wrong. Note you can navigate to this yourself by following the “View the built docs” link in the checks below. You can also build the docs and inspect them locally as I already mentioned above.
https://output.circle-artifacts.com/output/job/3f9b946e-a944-462c-836b-bfdfb4fe3a03/artifacts/0/doc/build/html/api/_as_gen/matplotlib.axes.Axes.quiver.html#matplotlib.axes.Axes.quiver

@amishamehta99 you have already been asked twice to check the rendering yourself before asking for review. It is not a good use of maintainers’ time to repeatedly point out problems that you could have checked yourself. Please do not ask for feedback again unless you have verified that the rendering is correct. If you do not know how to fix the rendering, then that is fine: you can close the PR and someone else can work on the problem.

Copy link
Copy Markdown
Contributor Author

The webagg timeout is indeed flaky and can be ignored.

The rendered docs for quiver still look wrong. Note you can navigate to this yourself by following the “View the built docs” link in the checks below. You can also build the docs and inspect them locally as I already mentioned above. https://output.circle-artifacts.com/output/job/3f9b946e-a944-462c-836b-bfdfb4fe3a03/artifacts/0/doc/build/html/api/_as_gen/matplotlib.axes.Axes.quiver.html#matplotlib.axes.Axes.quiver

@amishamehta99 you have already been asked twice to check the rendering yourself before asking for review. It is not a good use of maintainers’ time to repeatedly point out problems that you could have checked yourself. Please do not ask for feedback again unless you have verified that the rendering is correct. If you do not know how to fix the rendering, then that is fine: you can close the PR and someone else can work on the problem.

I verified the rendered documentation from the CI artifacts and the formulas now render correctly. Could you please check it out and suggest changes, if any.

amishamehta99 marked this pull request as ready for review March 9, 2026 15:15

story645 commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

this is what it looks like to me:

https://output.circle-artifacts.com/output/job/8a73a996-7226-4b56-ba8a-71dee664e77e/artifacts/0/doc/build/html/api/_as_gen/matplotlib.axes.Axes.quiver.html#matplotlib.axes.Axes.quiver

probably b/c the docs are currently indented to the same level as the parameters rather than the descriptions.

Copy link
Copy Markdown
Member

Also we build the docs as part of the ci, click on it and you can see 'em too:

story645 marked this pull request as draft March 11, 2026 02:12

Copy link
Copy Markdown
Contributor Author

Also we build the docs as part of the ci, click on it and you can see 'em too:

Hi @story645, thanks for the suggestion. I have tried to adjust the indentation.
However, in the rendered docs the two formula lines appear on the same line.
Should these be formatted as a literal block (using ::) to preserve line breaks?Asking this query before pushing the code.

Copy link
Copy Markdown
Member

I'd just make em bullets

amishamehta99 commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author
> I'd just make em bullets

Thanks! I updated the equations to bullet points and verified that the rendered documentation now displays them correctly. Is it correct?

amishamehta99 marked this pull request as ready for review March 12, 2026 09:09

story645 commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The whole point of this PR was to clean up the indent so the math formatting would render and you took away the math formatting (sorry I didn't catch that earlier) and bullets are supposed to be slightly indented under they're jntro. Thank you for your effort but I'm concerned at how many review cycles this is taking for fixing formatting.

story645 commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Sorry I was wrong about the slight indent (for bullets) :/

Please tell reviewers if they give you instructions that don't work and fix the mistake! This is what the final formatting is supposed to look like

story645 marked this pull request as draft March 12, 2026 18:31
amishamehta99 marked this pull request as ready for review March 12, 2026 18:44
amishamehta99 marked this pull request as draft March 12, 2026 19:37
amishamehta99 marked this pull request as ready for review March 12, 2026 20:30
amishamehta99 marked this pull request as draft March 12, 2026 20:37

Copy link
Copy Markdown
Contributor Author
Thanks for the clarification and for your patience while I worked through the formatting. I've updated the docstring and the rendered documentation now matches the expected layout. Please let me know if anything else needs adjustment.

Sorry I was wrong about the slight indent (for bullets) :/

Please tell reviewers if they give you instructions that don't work and fix the mistake! This is what the final formatting is supposed to look like

amishamehta99 marked this pull request as ready for review March 13, 2026 02:00

story645 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for finishing this out, please take more care understanding the problem and solution on your next pr.

story645 merged commit 69ca922 into matplotlib:main Mar 13, 2026
37 of 40 checks passed
QuLogic added this to the v3.11.0 milestone Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for finishing this out, please take more care understanding the problem and solution on your next pr.

Thank you for the review, feedback and trusting me with the fix!
I appreciate the guidance and will make sure to better understand the issue before submitting my next PR.

andreas16700 added a commit to andreas16700/matplotlib that referenced this pull request Mar 16, 2026
andreas16700 added a commit to andreas16700/matplotlib that referenced this pull request Mar 16, 2026
QuLogic mentioned this pull request Jun 4, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc]: bad rendering of matplotlib.pyplot.quiver docs

4 participants


Back | FazBrowse Home | New Git URL